Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 862093002: Split the event library into a cross-platform and native part. Part 1. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Split the event library into a cross-platform and native part. Part 1. This removes construction of ui::Event and subclasses from base::NativeEvents. It removes all usage of NativeEvents from that file. It moves the code from there to the ui/events/platform/ directory, which will eventually be its own library. The previous constructors have been refactored into ui/events/platform/platform_event_builder.h. Tests that relied on events were moved or rewritten. Also adds events_unittests to the build. BUG=443439 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1f3263d89a45bedf1e7b125d5981827951ab54d7

Patch Set 1 #

Patch Set 2 : Maybe fix android build. #

Patch Set 3 : Remove orphaned code from event_utils.h #

Total comments: 2

Patch Set 4 : sky comments #

Patch Set 5 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+724 lines, -930 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 3 chunks +5 lines, -2 lines 0 comments Download
M ui/events/cocoa/events_mac.mm View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M ui/events/event.h View 1 2 3 22 chunks +51 lines, -67 lines 0 comments Download
M ui/events/event.cc View 15 chunks +26 lines, -316 lines 0 comments Download
M ui/events/event_unittest.cc View 6 chunks +0 lines, -196 lines 0 comments Download
M ui/events/event_utils.h View 1 2 4 chunks +0 lines, -27 lines 0 comments Download
M ui/events/event_utils.cc View 1 2 2 chunks +0 lines, -55 lines 0 comments Download
M ui/events/events_stub.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D ui/events/ipc/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/events/ipc/OWNERS View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/events/ipc/latency_info_param_traits.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/events/platform/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
A ui/events/platform/platform_event_builder.h View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A ui/events/platform/platform_event_builder.cc View 1 chunk +282 lines, -0 lines 0 comments Download
A ui/events/platform/platform_event_builder_x_unittest.cc View 1 chunk +250 lines, -0 lines 0 comments Download
M ui/events/win/events_win.cc View 1 2 2 chunks +0 lines, -31 lines 0 comments Download
M ui/events/x/events_x.cc View 1 2 3 chunks +0 lines, -102 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M ui/platform_window/x11/x11_window.cc View 7 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Elliot Glaysher
This is an awkward place to send this out for review, but it's a reasonable ...
5 years, 11 months ago (2015-01-21 20:58:14 UTC) #2
sky
LGTM https://codereview.chromium.org/862093002/diff/40001/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/862093002/diff/40001/ui/events/event.h#newcode268 ui/events/event.h:268: gfx::Point screen_location() const { return screen_location_; } const ...
5 years, 11 months ago (2015-01-21 22:46:46 UTC) #3
Elliot Glaysher
5 years, 11 months ago (2015-01-21 23:13:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
1f3263d89a45bedf1e7b125d5981827951ab54d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698