Another attempt to land http://codereview.chromium.org/8589029.

Another attempt to land http://codereview.chromium.org/8589029.

Start of mini_installer build config refactoring.
Baby step one: 
- All intermediate files go into the intermediate directory.
- The packed_files.txt file is gone, and instead the mini_installer
  is baked from a resource file output into the intermediate dir.
- Cleanup use of implict global "options" in the python script.
- Use subprocess.call with a list instead of os.system.

R=robertshield@chromium.org,grt@chromium.org
BUG=102115
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111012

[Sigurður Ásgeirsson, 2011-11-21 19:26:50]

PTAL - the file names in the generated file are now quoted.

[robertshield, 2011-11-21 19:34:15]

lgtm

[grt (UTC plus 2), 2011-11-21 20:03:05]

lgtm

[commit-bot: I haz the power, 2011-11-21 20:29:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/siggi@chromium.org/8615002/3005

[commit-bot: I haz the power, 2011-11-21 22:21:05]

Change committed as 111012

[brucedawson, 2016-04-16 00:08:58]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-04-16 00:08:59]

https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
chrome/tools/build/win/create_installer_archive.py:154: file_path =
os.path.join(staging_dir, TEMP_ARCHIVE_DIR)
I hate to do a drive-by code review 52 months after the fact, but...

This function used to return two different directory names. The appended name
for file_path was changed by this CL from ARCHIVE_DIR to TEMP_ARCHIVE_DIR, so
now this function destroys and creates and returns the same directory twice.

I'm not sure what difference this makes - apparently nothing too serious since
it's been unnoticed for a long time. Thoughts?

[Sigurður Ásgeirsson, 2016-04-16 14:08:57]

Sadly I have no context for this - if there's a problem, maybe it's best to
just fix it?

On Fri, Apr 15, 2016 at 8:09 PM <brucedawson@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
> File chrome/tools/build/win/create_installer_archive.py (right):
>
>
>
https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
> chrome/tools/build/win/create_installer_archive.py:154: file_path =
> os.path.join(staging_dir, TEMP_ARCHIVE_DIR)
> I hate to do a drive-by code review 52 months after the fact, but...
>
> This function used to return two different directory names. The appended
> name for file_path was changed by this CL from ARCHIVE_DIR to
> TEMP_ARCHIVE_DIR, so now this function destroys and creates and returns
> the same directory twice.
>
> I'm not sure what difference this makes - apparently nothing too serious
> since it's been unnoticed for a long time. Thoughts?
>
> https://codereview.chromium.org/8615002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brucedawson, 2016-04-18 17:00:50]

On 2016/04/16 14:08:57, Sigurður Ásgeirsson wrote:
> Sadly I have no context for this - if there's a problem, maybe it's best to
> just fix it?

I'm not aware of any visible problem. I'll put it on my list of things to
investigate, but with no complaints for four years it's not gonna be high
priority.

[Nico, 2017-09-05 17:37:00]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-09-05 17:37:03]

https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
chrome/tools/build/win/create_installer_archive.py:154: file_path =
os.path.join(staging_dir, TEMP_ARCHIVE_DIR)
On 2016/04/16 00:08:59, brucedawson wrote:
> I hate to do a drive-by code review 52 months after the fact, but...
> 
> This function used to return two different directory names. The appended name
> for file_path was changed by this CL from ARCHIVE_DIR to TEMP_ARCHIVE_DIR, so
> now this function destroys and creates and returns the same directory twice.
> 
> I'm not sure what difference this makes - apparently nothing too serious since
> it's been unnoticed for a long time. Thoughts?

I noticed the same thing 57 months after the fact. I too am curious about this.

[Nico, 2017-09-05 17:38:10]

https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/8615002/diff/3005/chrome/tools/build/win/crea...
chrome/tools/build/win/create_installer_archive.py:154: file_path =
os.path.join(staging_dir, TEMP_ARCHIVE_DIR)
On 2017/09/05 17:37:02, Nico wrote:
> On 2016/04/16 00:08:59, brucedawson wrote:
> > I hate to do a drive-by code review 52 months after the fact, but...
> > 
> > This function used to return two different directory names. The appended
name
> > for file_path was changed by this CL from ARCHIVE_DIR to TEMP_ARCHIVE_DIR,
so
> > now this function destroys and creates and returns the same directory twice.
> > 
> > I'm not sure what difference this makes - apparently nothing too serious
since
> > it's been unnoticed for a long time. Thoughts?
> 
> I noticed the same thing 57 months after the fact. I too am curious about
this.

Ah, there's a reply on the toplevel issue here:
https://codereview.chromium.org/8615002/#msg8

Guess I'll send a CL to clean this up.