Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Side by Side Diff: content/public/browser/navigator_connect_service.h

Issue 861373002: Refactor navigator.connect code to make it more flexible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lower similarity threshold Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_METRICS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATOR_CONNECT_SERVICE_H_
6 #define CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_METRICS_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATOR_CONNECT_SERVICE_H_
7 7
8 #include <string>
9 #include <vector> 8 #include <vector>
10 9
11 namespace ppapi { 10 #include "base/strings/string16.h"
12 struct Preferences; 11
13 } 12 class GURL;
14 13
15 namespace content { 14 namespace content {
16 15
17 // Record size metrics for all Flash instances. 16 // Implementations of NavigatorConnectServiceFactory should return a new
18 void RecordFlashSizeMetric(int width, int height); 17 // instance of this class when accepting a connection. All messages send to the
scheib 2015/01/23 22:03:58 send->sent
Marijn Kruisselbrink 2015/01/26 21:34:26 Done.
18 // service will then be passed to the OnMessage method.
19 // Instances of this class are owned by NavigatorConnectContext.
20 class NavigatorConnectService {
21 public:
22 virtual ~NavigatorConnectService() {}
19 23
20 // Records size metrics for Flash instances that are clicked. 24 virtual void OnMessage(const base::string16& message,
21 void RecordFlashClickSizeMetric(int width, int height); 25 const std::vector<int>& sent_message_port_ids) = 0;
22 26 };
23 void SetGPUHistogram(const ppapi::Preferences& prefs,
24 const std::vector<std::string>& arg_names,
25 const std::vector<std::string>& arg_values);
26 27
27 } // namespace content 28 } // namespace content
28 29
29 #endif // CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_METRICS_H_ 30 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATOR_CONNECT_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698