Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 861203003: Add output scale factor command line parameter to pdfium_test. (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add output scale factor command line parameter to pdfium_test. It turns out that pdfium rendering takes some significantly different paths when the output bitmap size is the same as the document size, since it can avoid work in that case. For example, to reproduce the referenced bug, a scale factor less than 1.0 is required, so we add a parameter to let pdfium_test cover that case. BUG=451265 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/daa2e84dfca2f1cf39e064bd9ad6ee3e2cd70825

Patch Set 1 #

Total comments: 3

Patch Set 2 : Set default value for |scale|. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M samples/pdfium_test.cc View 1 8 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Tom Sepez
Lei, please review.
4 years, 3 months ago (2015-01-29 19:50:00 UTC) #2
Lei Zhang
lgtm, though there's a few typos in the CL description. https://codereview.chromium.org/861203003/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/861203003/diff/1/samples/pdfium_test.cc#newcode13 ...
4 years, 3 months ago (2015-01-29 22:15:18 UTC) #3
Tom Sepez
> Is this the preferred way to do StringToDouble() in the absense of > string_number_conversions.h? ...
4 years, 3 months ago (2015-01-29 23:37:19 UTC) #4
Tom Sepez
https://codereview.chromium.org/861203003/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/861203003/diff/1/samples/pdfium_test.cc#newcode13 samples/pdfium_test.cc:13: #include <sstream> On 2015/01/29 22:15:18, Lei Zhang wrote: > ...
4 years, 3 months ago (2015-01-29 23:37:32 UTC) #5
Lei Zhang
Ok, sounds good. s/comand/command/ s/takse/takes/ s/referened/referenced/
4 years, 3 months ago (2015-01-29 23:40:56 UTC) #6
Tom Sepez
4 years, 3 months ago (2015-01-29 23:44:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
daa2e84dfca2f1cf39e064bd9ad6ee3e2cd70825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698