Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: chrome/android/java/res/layout/account_chooser_infobar_items.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/account_chooser_infobar_items.xml
diff --git a/chrome/android/java/res/layout/account_chooser_infobar_items.xml b/chrome/android/java/res/layout/account_chooser_infobar_items.xml
new file mode 100644
index 0000000000000000000000000000000000000000..694185e64af54daf68b41948e29b2f739068bf34
--- /dev/null
+++ b/chrome/android/java/res/layout/account_chooser_infobar_items.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
newt (away) 2015/02/18 22:26:02 I'd name this file something like "account_chooser
melandory 2015/02/19 13:38:00 Done.
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+<FrameLayout
newt (away) 2015/02/18 22:26:02 You don't need this FrameLayout. The ListView itse
melandory 2015/02/18 22:31:57 This way I can't control height of ListView, becau
newt (away) 2015/02/19 00:00:48 In fact, you can remove the FrameLayout. Then, in
melandory 2015/02/19 14:01:52 As far as I understood it won't work if I remove F
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content">
+ <ListView
+ android:id="@+id/account_chooser_layout"
newt (away) 2015/02/18 22:26:02 I'd change this ID to "account_list" (or you may n
melandory 2015/02/19 13:38:00 Done.
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:padding="8dp"
+ android:orientation="vertical"/>
newt (away) 2015/02/19 00:00:48 orientation doesn't apply to ListView
melandory 2015/02/19 13:38:00 Done.
+</FrameLayout>

Powered by Google App Engine
This is Rietveld 408576698