chrome/android/java/res/layout/account_chooser_infobar_items.xml - Issue 861103002: Credentials chooser UI for Android.

Side by Side Diff: chrome/android/java/res/layout/account_chooser_infobar_items.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/account_chooser_infobar_item.xml ('k') | chrome/android/java/res/menu/account_chooser_infobar_more_menu_popup.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2015/02/18 22:26:02 I'd name this file something like "account_chooser I'd name this file something like "account_chooser_infobar_list.xml" melandory 2015/02/19 13:38:00 Done. Show quoted text On 2015/02/18 22:26:02, newt wrote: > I'd name this file something like "account_chooser_infobar_list.xml" Done.
	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5 <FrameLayout
	newt (away) 2015/02/18 22:26:02 You don't need this FrameLayout. The ListView itse You don't need this FrameLayout. The ListView itself can be the root. melandory 2015/02/18 22:31:57 This way I can't control height of ListView, becau Show quoted text On 2015/02/18 22:26:02, newt wrote: > You don't need this FrameLayout. The ListView itself can be the root. This way I can't control height of ListView, because listView.getLayoutParams(); returns null. newt (away) 2015/02/19 00:00:48 In fact, you can remove the FrameLayout. Then, in Show quoted text On 2015/02/18 22:31:57, melandory wrote: > On 2015/02/18 22:26:02, newt wrote: > > You don't need this FrameLayout. The ListView itself can be the root. > > This way I can't control height of ListView, because listView.getLayoutParams(); > returns null. In fact, you can remove the FrameLayout. Then, in AccountChooserInfoBar.java, you can just create LayoutParams from scratch (see my comment in AccountChooserInfoBar) melandory 2015/02/19 14:01:52 As far as I understood it won't work if I remove F Show quoted text On 2015/02/19 00:00:48, newt wrote: > On 2015/02/18 22:31:57, melandory wrote: > > On 2015/02/18 22:26:02, newt wrote: > > > You don't need this FrameLayout. The ListView itself can be the root. > > > > This way I can't control height of ListView, because > listView.getLayoutParams(); > > returns null. > > In fact, you can remove the FrameLayout. Then, in AccountChooserInfoBar.java, > you can just create LayoutParams from scratch (see my comment in > AccountChooserInfoBar) As far as I understood it won't work if I remove FrameLayout because then I need to work with InfoBarLayout.LayoutParams (for details see comment in AccountChooserInfoBar)
	6 xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:layout_width="wrap_content"

	8 android:layout_height="wrap_content">

	9 <ListView

	10 android:id="@+id/account_chooser_layout"
	newt (away) 2015/02/18 22:26:02 I'd change this ID to "account_list" (or you may n I'd change this ID to "account_list" (or you may not even need the ID at all once you make the ListView the root of this file) melandory 2015/02/19 13:38:00 Done. Show quoted text On 2015/02/18 22:26:02, newt wrote: > I'd change this ID to "account_list" (or you may not even need the ID at all > once you make the ListView the root of this file) Done.
	11 android:layout_width="match_parent"

	12 android:layout_height="wrap_content"

	13 android:padding="8dp"

	14 android:orientation="vertical"/>
	newt (away) 2015/02/19 00:00:48 orientation doesn't apply to ListView orientation doesn't apply to ListView melandory 2015/02/19 13:38:00 Done. Show quoted text On 2015/02/19 00:00:48, newt wrote: > orientation doesn't apply to ListView Done.
	15 </FrameLayout>

OLD	NEW