Credentials chooser UI for Android.

chrome/android/java/res/layout/credential_picker_infobar_item.xml

Index: chrome/android/java/res/layout/credential_picker_infobar_item.xml
diff --git a/chrome/android/java/res/layout/credential_picker_infobar_item.xml b/chrome/android/java/res/layout/credential_picker_infobar_item.xml
new file mode 100644
index 0000000000000000000000000000000000000000..49da88e85da28b7f8acee0dea10e59434e2316d4
--- /dev/null
+++ b/chrome/android/java/res/layout/credential_picker_infobar_item.xml
@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<LinearLayout
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:layout_width="fill_parent"

[newt (away), 2015/02/04 22:17:51]

use match_parent instead of fill_parent. They're synonyms, but we use
match_parent for consistency.

[melandory, 2015/02/05 14:45:36]

Done.

+    android:layout_height="wrap_content"
+    android:padding="8dp"
+    android:background="?attr/selectableItemBackground"

[newt (away), 2015/02/04 22:17:51]

don't need selectableItemBackground once you start using a ListView (as I
mentioned in AccountChooseInfobar.java)

+    android:orientation="horizontal" >
+    <ImageView
+        android:id="@+id/credentials_app_image"

[newt (away), 2015/02/04 22:17:51]

why "app_image"? Isn't this a user profile image? How about calling this
"profile_image"? The IDs below could also be improved.

[melandory, 2015/02/05 14:45:36]

Done.

+        android:layout_gravity="center_vertical"
+        android:layout_width="32dp"
+        android:layout_height="32dp"
+        android:contentDescription="@null"/>
+    <LinearLayout
+        android:layout_margin="8dp"
+        android:layout_gravity="center_vertical"
+        android:layout_width="wrap_content"

[newt (away), 2015/02/04 22:17:51]

use layout_width="0dp" and layout_weight="1". That'll make this view expand
horizontally to take up the available space.

[melandory, 2015/02/17 16:16:57]

Done.

+        android:layout_height="wrap_content"
+        android:orientation="vertical">
+        <TextView
+            android:id="@+id/credentials_app_name"

[newt (away), 2015/02/04 22:17:51]

attributes should be in this order:
 - id
 - layout_width
 - layout_height
 - other layout_* attributes
 - other attributes, typically alphabetized

[melandory, 2015/02/05 14:45:36]

Done.

+            android:textAppearance="?android:attr/textAppearanceMedium"

[newt (away), 2015/02/04 22:17:51]

textAppearanceMedium and textAppearanceSmall have different colors and sizes on
Android L devices compared to pre-L devices. You should probably specify the
font color and size explicitly.

[melandory, 2015/02/05 14:45:36]

I'll take this into account. I've chosen same font settings as Indentity team
who is implementing this infobar for Android. So I prefer to discuss this with
them and have similar appearance.

+            android:singleLine="true"
+            android:ellipsize="end"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"/>
+        <TextView
+            android:id="@+id/credentials_app_credential_name"
+            android:textAppearance="?android:attr/textAppearanceSmall"
+            android:singleLine="true"
+            android:ellipsize="end"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"/>
+    </LinearLayout>
+</LinearLayout>