chrome/android/java/res/layout/credential_picker_infobar_item.xml - Issue 861103002: Credentials chooser UI for Android.

Side by Side Diff: chrome/android/java/res/layout/credential_picker_infobar_item.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased on top of master Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/credential_picker_buttonbar.xml ('K') | « chrome/android/java/res/layout/credential_picker_buttonbar.xml ('k') | chrome/android/java/res/layout/credential_picker_infobar_items.xml » ('j') | chrome/android/java/res/layout/credential_picker_infobar_items.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="fill_parent"
	newt (away) 2015/02/04 22:17:51 use match_parent instead of fill_parent. They're s use match_parent instead of fill_parent. They're synonyms, but we use match_parent for consistency. melandory 2015/02/05 14:45:36 Done. Show quoted text On 2015/02/04 22:17:51, newt wrote: > use match_parent instead of fill_parent. They're synonyms, but we use > match_parent for consistency. Done.
	9 android:layout_height="wrap_content"

	10 android:padding="8dp"

	11 android:background="?attr/selectableItemBackground"
	newt (away) 2015/02/04 22:17:51 don't need selectableItemBackground once you start don't need selectableItemBackground once you start using a ListView (as I mentioned in AccountChooseInfobar.java)
	12 android:orientation="horizontal" >

	13 <ImageView

	14 android:id="@+id/credentials_app_image"
	newt (away) 2015/02/04 22:17:51 why "app_image"? Isn't this a user profile image? why "app_image"? Isn't this a user profile image? How about calling this "profile_image"? The IDs below could also be improved. melandory 2015/02/05 14:45:36 Done. Show quoted text On 2015/02/04 22:17:51, newt wrote: > why "app_image"? Isn't this a user profile image? How about calling this > "profile_image"? The IDs below could also be improved. Done.
	15 android:layout_gravity="center_vertical"

	16 android:layout_width="32dp"

	17 android:layout_height="32dp"

	18 android:contentDescription="@null"/>

	19 <LinearLayout

	20 android:layout_margin="8dp"

	21 android:layout_gravity="center_vertical"

	22 android:layout_width="wrap_content"
	newt (away) 2015/02/04 22:17:51 use layout_width="0dp" and layout_weight="1". That use layout_width="0dp" and layout_weight="1". That'll make this view expand horizontally to take up the available space. melandory 2015/02/17 16:16:57 Done. Show quoted text On 2015/02/04 22:17:51, newt wrote: > use layout_width="0dp" and layout_weight="1". That'll make this view expand > horizontally to take up the available space. Done.
	23 android:layout_height="wrap_content"

	24 android:orientation="vertical">

	25 <TextView

	26 android:id="@+id/credentials_app_name"
	newt (away) 2015/02/04 22:17:51 attributes should be in this order: - id - layou attributes should be in this order: - id - layout_width - layout_height - other layout_* attributes - other attributes, typically alphabetized melandory 2015/02/05 14:45:36 Done. Show quoted text On 2015/02/04 22:17:51, newt wrote: > attributes should be in this order: > - id > - layout_width > - layout_height > - other layout_* attributes > - other attributes, typically alphabetized Done.
	27 android:textAppearance="?android:attr/textAppearanceMedium"
	newt (away) 2015/02/04 22:17:51 textAppearanceMedium and textAppearanceSmall have textAppearanceMedium and textAppearanceSmall have different colors and sizes on Android L devices compared to pre-L devices. You should probably specify the font color and size explicitly. melandory 2015/02/05 14:45:36 I'll take this into account. I've chosen same font Show quoted text On 2015/02/04 22:17:51, newt wrote: > textAppearanceMedium and textAppearanceSmall have different colors and sizes on > Android L devices compared to pre-L devices. You should probably specify the > font color and size explicitly. I'll take this into account. I've chosen same font settings as Indentity team who is implementing this infobar for Android. So I prefer to discuss this with them and have similar appearance.
	28 android:singleLine="true"

	29 android:ellipsize="end"

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"/>

	32 <TextView

	33 android:id="@+id/credentials_app_credential_name"

	34 android:textAppearance="?android:attr/textAppearanceSmall"

	35 android:singleLine="true"

	36 android:ellipsize="end"

	37 android:layout_width="wrap_content"

	38 android:layout_height="wrap_content"/>

	39 </LinearLayout>

	40 </LinearLayout>

OLD	NEW