Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: sky/specs/events.md

Issue 861013002: Specs: specced TapGesture, added some TODOs around events, and put in a placeholder for ScrollGestu… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/specs/gestures.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/events.md
diff --git a/sky/specs/events.md b/sky/specs/events.md
index 09ecb247fb102c43122016310d81dae48438b8e9..1ae7492f895235cadb4b5d9a8108629b2b136efc 100644
--- a/sky/specs/events.md
+++ b/sky/specs/events.md
@@ -18,6 +18,17 @@ Sky Event Model
// TODO(ianh): do events get retargetted, e.g. focus when leaving a custom element?
}
+ // TODO(ianh): decide if we're using this generic Event class and
+ // allowing any arbitrary properties to be set on it, or if we're
+ // going to use subclasses (and drop "type"). If we use subclasses
+ // then how will declarative event handling work in frameworks?
+ // (consider that multiple modules can each have their own FooEvent
+ // class with the same name...)
+ //
+ // The advantage of this would be the ability to enforce (or at
+ // least better catch) incorrect uses of the API, e.g. to make sure
+ // people don't stop on themselves in 'pointer-down' capture.
+
callback EventListener any (Event event);
// if the return value is not undefined:
// assign it to event.result
« no previous file with comments | « no previous file | sky/specs/gestures.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698