Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 860983003: Adding "static_assert" in lieu of "COMPILE_ASSERT" in google_apis module (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding "static_assert" in lieu of "COMPILE_ASSERT" in google_apis module All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now. BUG=442514 Committed: https://crrev.com/ceeb4976a531646f84d4c37d0ac4abcaccc74c22 Cr-Commit-Position: refs/heads/master@{#312436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M google_apis/gcm/base/mcs_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/base/mcs_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-21 12:04:44 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 11 months ago (2015-01-21 15:36:56 UTC) #3
anujsharma
On 2015/01/21 15:36:56, Roger Tawa wrote: > lgtm Thanks roger for lgtm.
5 years, 11 months ago (2015-01-21 17:49:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860983003/1
5 years, 11 months ago (2015-01-21 17:50:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 20:39:27 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 20:40:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceeb4976a531646f84d4c37d0ac4abcaccc74c22
Cr-Commit-Position: refs/heads/master@{#312436}

Powered by Google App Engine
This is Rietveld 408576698