google_apis/gcm/base/mcs_util.cc - Issue 860983003: Adding "static_assert" in lieu of "COMPILE_ASSERT" in google_apis module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/base/mcs_util.cc

Issue 860983003: Adding "static_assert" in lieu of "COMPILE_ASSERT" in google_apis module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/base/mcs_util.cc

diff --git a/google_apis/gcm/base/mcs_util.cc b/google_apis/gcm/base/mcs_util.cc

index ceccc957cbe1659c86eb34ba4ca94b608010b004..7dd9d7b594b518d567bcf8334770f001b7d6f2de 100644

--- a/google_apis/gcm/base/mcs_util.cc

+++ b/google_apis/gcm/base/mcs_util.cc

@@ -36,8 +36,8 @@ const char* kProtoNames[] = {

"mcs_proto.BindAccountResponse",

"mcs_proto.TalkMetadata"

};

-COMPILE_ASSERT(arraysize(kProtoNames) == kNumProtoTypes,

- ProtoNamesMustIncludeAllTags);

+static_assert(arraysize(kProtoNames) == kNumProtoTypes,

+ "Proto Names Must Include All Tags");

const char kLoginId[] = "chrome-";

const char kLoginDomain[] = "mcs.android.com";

« no previous file with comments | « no previous file | google_apis/gcm/base/mcs_util_unittest.cc » ('j') | no next file with comments »