components/cronet/android/java/src/org/chromium/net/UrlRequest.java - Issue 860893002: [Cronet] Allow UrlRequest bypass cache

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequest.java

Issue 860893002: [Cronet] Allow UrlRequest bypass cache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/cronet_url_request_adapter.cc ('K') | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java ('k') | components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/UrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequest.java b/components/cronet/android/java/src/org/chromium/net/UrlRequest.java

index b78dd6313f41db201860790ca8a0e44833cef430..f198b7f1f38995811b79df485b9b7c11e1511e6c 100644

--- a/components/cronet/android/java/src/org/chromium/net/UrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequest.java

@@ -91,6 +91,12 @@ public interface UrlRequest {

public void resume();

/**

+ * Bypasses cache for the request. If context is not set up to use cache,

+ * this call has no effect.

+ */

+ public void bypassCache();

mef 2015/01/30 16:06:08 I'm a bit hesitant about calling it 'bypassCache'

xunjieli 2015/01/30 22:39:46 Not sure what naming scheme will best suit in this

mef 2015/02/04 20:39:42 "setUseCachesFalse" seems a bit wordy. Maybe "disa

mmenke 2015/02/04 20:54:33 I'm fine with disableCache. Other options I don't

+ /**

* Note: There are deliberately no accessors for the results of the request

* here. Having none removes any ambiguity over when they are populated,

* particularly in the redirect case.