Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: components/cronet/android/java/src/org/chromium/net/UrlRequest.java

Issue 860893002: [Cronet] Allow UrlRequest bypass cache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 /** 7 /**
8 * HTTP request (GET, PUT or POST). 8 * HTTP request (GET, PUT or POST).
9 * Note: All methods must be called on the Executor passed in during creation. 9 * Note: All methods must be called on the Executor passed in during creation.
10 */ 10 */
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 */ 84 */
85 public boolean isPaused(); 85 public boolean isPaused();
86 86
87 /** 87 /**
88 * When resuming, any pending callback to the listener will be called 88 * When resuming, any pending callback to the listener will be called
89 * asynchronously. 89 * asynchronously.
90 */ 90 */
91 public void resume(); 91 public void resume();
92 92
93 /** 93 /**
94 * Bypasses cache for the request. If context is not set up to use cache,
95 * this call has no effect.
96 */
97 public void bypassCache();
mef 2015/01/30 16:06:08 I'm a bit hesitant about calling it 'bypassCache'
xunjieli 2015/01/30 22:39:46 Not sure what naming scheme will best suit in this
mef 2015/02/04 20:39:42 "setUseCachesFalse" seems a bit wordy. Maybe "disa
mmenke 2015/02/04 20:54:33 I'm fine with disableCache. Other options I don't
98
99 /**
94 * Note: There are deliberately no accessors for the results of the request 100 * Note: There are deliberately no accessors for the results of the request
95 * here. Having none removes any ambiguity over when they are populated, 101 * here. Having none removes any ambiguity over when they are populated,
96 * particularly in the redirect case. 102 * particularly in the redirect case.
97 */ 103 */
98 } 104 }
99 105
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698