Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 860873002: Continue deleting code in ui/. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Continue deleting code in ui/. This moves ui/base/hit_test.h into its one consumer, services/window_manager/, and moves the only part of cursor.h that is still used into platform_window.h. BUG=443439 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ad08bd043ac803278a782f67f4a14f98396ce83d

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4385 lines) Patch
M services/window_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A + services/window_manager/hit_test.h View 1 2 chunks +4 lines, -8 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 5 chunks +1 line, -57 lines 0 comments Download
D ui/base/cursor/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/base/cursor/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/base/cursor/cursor.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/base/hit_test.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/base/ui_base_switches.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/base/ui_base_switches.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/base/view_prop.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/base/view_prop.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D ui/base/view_prop_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D ui/base/win/accessibility_ids_win.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/base/win/accessibility_misc_utils.h View 1 chunk +0 lines, -95 lines 0 comments Download
D ui/base/win/accessibility_misc_utils.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/base/win/atl_module.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ui/base/win/foreground_helper.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ui/base/win/foreground_helper.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/base/win/hidden_window.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/base/win/hidden_window.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/base/win/hwnd_subclass.h View 1 chunk +0 lines, -83 lines 0 comments Download
D ui/base/win/hwnd_subclass.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D ui/base/win/hwnd_subclass_unittest.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D ui/base/win/internal_constants.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/base/win/internal_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D ui/base/win/lock_state.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/base/win/lock_state.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/base/win/message_box_win.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ui/base/win/message_box_win.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/base/win/mouse_wheel_util.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/base/win/mouse_wheel_util.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D ui/base/win/open_file_name_win.h View 1 chunk +0 lines, -86 lines 0 comments Download
D ui/base/win/open_file_name_win.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D ui/base/win/open_file_name_win_unittest.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D ui/base/win/scoped_ole_initializer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/base/win/scoped_ole_initializer.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/base/win/shell.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ui/base/win/shell.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D ui/base/win/touch_input.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/base/win/touch_input.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/base/win/window_event_target.h View 1 chunk +0 lines, -86 lines 0 comments Download
D ui/base/win/window_event_target.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D ui/base/x/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/base/x/x11_util.h View 1 chunk +0 lines, -352 lines 0 comments Download
D ui/base/x/x11_util.cc View 1 chunk +0 lines, -1375 lines 0 comments Download
D ui/base/x/x11_util_internal.h View 1 chunk +0 lines, -49 lines 0 comments Download
M ui/platform_window/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/platform_window/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/platform_window/platform_window.h View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Elliot Glaysher
5 years, 11 months ago (2015-01-20 19:06:09 UTC) #2
sky
LGTM https://codereview.chromium.org/860873002/diff/1/services/window_manager/hit_test.h File services/window_manager/hit_test.h (right): https://codereview.chromium.org/860873002/diff/1/services/window_manager/hit_test.h#newcode1 services/window_manager/hit_test.h:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 11 months ago (2015-01-20 20:01:50 UTC) #3
Elliot Glaysher
5 years, 11 months ago (2015-01-20 20:18:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ad08bd043ac803278a782f67f4a14f98396ce83d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698