Issue 860843006: Delete blink::ImageQualityController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 860843006: Delete blink::ImageQualityController (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Delete blink::ImageQualityController Instead, always use InterpolationLow. In Skia, that boils down to bilinear, which is fast on GPUs. We should eventually let authors control the interpolation quality in case they want pixelation, etc. This CL saves 6.3% on Layer::RecordPicture for flights-app. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c09b473ba58ae1f5c82731a9720feb1c85a74575

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -328 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/core/rendering/ImageQualityController.h	View	1 chunk	+0 lines, -82 lines	0 comments	Download
D	sky/engine/core/rendering/ImageQualityController.cpp	View	1 chunk	+0 lines, -224 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBoxModelObject.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBoxModelObject.cpp	View	4 chunks	+1 line, -14 lines	0 comments	Download
M	sky/engine/core/rendering/RenderImage.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 11 months ago (2015-01-21 19:29:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c09b473ba58ae1f5c82731a9720feb1c85a74575 (presubmit successful).