Chromium Code Reviews| Index: tools/testing/dart/status_reporter.dart |
| diff --git a/tools/testing/dart/status_reporter.dart b/tools/testing/dart/status_reporter.dart |
| index 80d0ef7178ab3a9bfc5039c79dbce996a8d9b4f5..7263a40f18c2152b7d6d90f54194f67993f4f569 100644 |
| --- a/tools/testing/dart/status_reporter.dart |
| +++ b/tools/testing/dart/status_reporter.dart |
| @@ -90,16 +90,18 @@ List<Map> getCombinations() { |
| return COMBINATIONS[Platform.operatingSystem]; |
| } |
| -void ensureBuild() { |
| +void ensureBuild(Iterable<String> archs) { |
| print('Building many platforms. Please be patient.'); |
| - var archs = Platform.operatingSystem == 'linux' |
| - ? '-aia32,x64,simarm,simmips' |
| - : '-aia32,x64'; |
| - var result = Process.runSync('python', |
| - ['tools/build.py', '-mrelease,debug', archs, 'create_sdk', |
| - // We build runtime to be able to list cc tests |
| - 'runtime']); |
| + var archString = '-a${archs.join(',')}'; |
| + |
| + var args = ['tools/build.py', '-mrelease,debug', archString, 'create_sdk', |
| + // We build runtime to be able to list cc tests |
| + 'runtime']; |
| + |
| + print(args.join(' ')); |
|
ricow1
2015/01/20 06:15:05
print('Running: python ${args.join(" ")}');
kevmoo
2015/01/20 16:48:10
Done.
|
| + |
| + var result = Process.runSync('python', args); |
| if (result.exitCode != 0) { |
| print('ERROR'); |
| @@ -130,10 +132,18 @@ void sanityCheck(String output) { |
| } |
| void main(List<String> args) { |
| - ensureBuild(); |
| + var combinations = getCombinations(); |
| + |
| + var arches = new Set<String>(); |
|
ricow1
2015/01/20 06:15:05
something like:
var arches = combinations.fold(new
kevmoo
2015/01/20 16:48:10
Done.
|
| + for (var combo in combinations) { |
| + var comboArches = combo['archs']; |
| + arches.addAll(comboArches); |
| + } |
| + |
| + ensureBuild(arches); |
| List<String> keys; |
| - for (var combination in getCombinations()) { |
| + for (var combination in combinations) { |
| for (var mode in combination['modes']) { |
| for (var arch in combination['archs']) { |
| for (var runtime in combination['runtimes']) { |
| @@ -148,8 +158,8 @@ void main(List<String> args) { |
| throw new Exception("Error running: ${args.join(" ")}"); |
| } |
| - // Find Total: 15063 tests |
| - // Everything after this will be the report. |
| + // Find "JSON:" |
| + // Everything after will the JSON-formatted output |
|
ricow1
2015/01/20 06:15:05
. at end of comment, consider also saying "because
kevmoo
2015/01/20 16:48:10
Done.
|
| var totalIndex = result.stdout.indexOf('JSON:'); |
| var report = result.stdout.substring(totalIndex + 5); |