cleanup to status_reporter

tools/testing/dart/status_reporter.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 import 'dart:convert';
 
 List<Map> LINUX_COMBINATIONS = [
     {
       'runtimes' : ['none'],
@@ skipping 72 matching lines @@
 Map<String, List<Map>> COMBINATIONS = {
   'linux' : LINUX_COMBINATIONS,
   'windows' : WINDOWS_COMBINATIONS,
   'macos' : MACOS_COMBINATIONS
 };
 
 List<Map> getCombinations() {
   return COMBINATIONS[Platform.operatingSystem];
 }
 
-void ensureBuild() {
+void ensureBuild(Iterable<String> archs) {
   print('Building many platforms. Please be patient.');
-  var archs = Platform.operatingSystem == 'linux'
-    ? '-aia32,x64,simarm,simmips'
-    : '-aia32,x64';
 
-  var result = Process.runSync('python',
-      ['tools/build.py', '-mrelease,debug', archs, 'create_sdk',
-      // We build runtime to be able to list cc tests
-      'runtime']);
+  var archString = '-a${archs.join(',')}';
+
+  var args = ['tools/build.py', '-mrelease,debug', archString, 'create_sdk',
+    // We build runtime to be able to list cc tests
+    'runtime'];
+
+  print(args.join(' '));

[ricow1, 2015/01/20 06:15:05]

print('Running: python ${args.join(" ")}');

[kevmoo, 2015/01/20 16:48:10]

Done.

+
+  var result = Process.runSync('python', args);
 
   if (result.exitCode != 0) {
     print('ERROR');
     print(result.stderr);
     throw new Exception('Error while building.');
   }
   print('Done building.');
 }
 
 void sanityCheck(String output) {
@@ skipping 10 matching lines @@
     count += int.parse(lines[i].split(' ')[2].trim());
   }
   if (count != total) {
     print('Count: $count, total: $total');
     throw new Exception(
         'Count and total do not align. Please validate manually.');
   }
 }
 
 void main(List<String> args) {
-  ensureBuild();
+  var combinations = getCombinations();
+
+  var arches = new Set<String>();

[ricow1, 2015/01/20 06:15:05]

something like:
var arches = combinations.fold(new Set<String>(), (set, value) =>
set.addAll(value));

[kevmoo, 2015/01/20 16:48:10]

Done.

+  for (var combo in combinations) {
+    var comboArches = combo['archs'];
+    arches.addAll(comboArches);
+  }
+
+  ensureBuild(arches);
 
   List<String> keys;
-  for (var combination in getCombinations()) {
+  for (var combination in combinations) {
     for (var mode in combination['modes']) {
       for (var arch in combination['archs']) {
         for (var runtime in combination['runtimes']) {
           var compiler = combination['compiler'];
 
           var args = ['tools/test.py', '-m$mode', '-c$compiler', '-r$runtime',
                       '-a$arch', '--report-in-json', '--use-sdk'];
           var result = Process.runSync('python', args);
           if (result.exitCode != 0) {
             print(result.stdout);
             print(result.stderr);
             throw new Exception("Error running: ${args.join(" ")}");
           }
 
-          // Find Total: 15063 tests
-          // Everything after this will be the report.
+          // Find "JSON:"
+          // Everything after will the JSON-formatted output

[ricow1, 2015/01/20 06:15:05]

. at end of comment, consider also saying "because of the --report-in-json flag
used above."

[kevmoo, 2015/01/20 16:48:10]

Done.

           var totalIndex = result.stdout.indexOf('JSON:');
           var report = result.stdout.substring(totalIndex + 5);
 
           var map = JSON.decode(report) as Map;
 
           if (keys == null) {
             keys = map.keys.toList();
             var firstKey = keys.removeAt(0);
             if (firstKey != 'total') {
               throw '"total" should be the first key';
@@ skipping 15 matching lines @@
             var pct = 100*(value/total);
             values.add('${pct.toStringAsFixed(3)}%');
           }
 
           print(values.join(','));
         }
       }
     }
   }
 }