Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 860603002: Don't use -Wl,-z,defs for asan and tsan builds for now. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use -Wl,-z,defs for asan and tsan builds for now. BUG=449843, 443987 TBR=inferno@chromium.org Committed: https://crrev.com/302bce218305106489b832a014b4a675aaab4292 Cr-Commit-Position: refs/heads/master@{#312071}

Patch Set 1 #

Patch Set 2 : lolg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
5 years, 11 months ago (2015-01-19 03:56:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860603002/1
5 years, 11 months ago (2015-01-19 03:58:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/2182) Try jobs failed on following ...
5 years, 11 months ago (2015-01-19 04:02:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860603002/20001
5 years, 11 months ago (2015-01-19 04:09:17 UTC) #8
inferno
lgtm
5 years, 11 months ago (2015-01-19 04:20:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-19 05:45:24 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 05:46:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/302bce218305106489b832a014b4a675aaab4292
Cr-Commit-Position: refs/heads/master@{#312071}

Powered by Google App Engine
This is Rietveld 408576698