Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: build/common.gypi

Issue 860603002: Don't use -Wl,-z,defs for asan and tsan builds for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lolg Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3517 matching lines...) Expand 10 before | Expand all | Expand 10 after
3528 }], 3528 }],
3529 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580 3529 # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
3530 ['os_posix==1 and disable_fatal_linker_warnings==0 and use_evdev_gestures==0 and (chromeos==0 or target_arch!="arm")', { 3530 ['os_posix==1 and disable_fatal_linker_warnings==0 and use_evdev_gestures==0 and (chromeos==0 or target_arch!="arm")', {
3531 'target_defaults': { 3531 'target_defaults': {
3532 'ldflags': [ 3532 'ldflags': [
3533 '-Wl,--fatal-warnings', 3533 '-Wl,--fatal-warnings',
3534 ], 3534 ],
3535 }, 3535 },
3536 }], 3536 }],
3537 # TODO(thakis): Enable this everywhere. http://crbug.com/371125 3537 # TODO(thakis): Enable this everywhere. http://crbug.com/371125
3538 ['OS=="linux" and chromeos==0 and component=="shared_library" and use_ozone! =1 and buildtype!="Official"', { 3538 ['OS=="linux" and chromeos==0 and asan==0 and tsan==0 and component=="shared _library" and use_ozone!=1 and buildtype!="Official"', {
3539 'target_defaults': { 3539 'target_defaults': {
3540 'ldflags': [ 3540 'ldflags': [
3541 '-Wl,-z,defs', 3541 '-Wl,-z,defs',
3542 ], 3542 ],
3543 }, 3543 },
3544 }], 3544 }],
3545 ['os_posix==1 and chromeos==0', { 3545 ['os_posix==1 and chromeos==0', {
3546 # Chrome OS enables -fstack-protector-strong via its build wrapper, 3546 # Chrome OS enables -fstack-protector-strong via its build wrapper,
3547 # and we want to avoid overriding this, so stack-protector is only 3547 # and we want to avoid overriding this, so stack-protector is only
3548 # enabled when not building on Chrome OS. 3548 # enabled when not building on Chrome OS.
(...skipping 2300 matching lines...) Expand 10 before | Expand all | Expand 10 after
5849 # settings in target dicts. SYMROOT is a special case, because many other 5849 # settings in target dicts. SYMROOT is a special case, because many other
5850 # Xcode variables depend on it, including variables such as 5850 # Xcode variables depend on it, including variables such as
5851 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5851 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5852 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5852 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5853 # files to appear (when present) in the UI as actual files and not red 5853 # files to appear (when present) in the UI as actual files and not red
5854 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5854 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5855 # and therefore SYMROOT, needs to be set at the project level. 5855 # and therefore SYMROOT, needs to be set at the project level.
5856 'SYMROOT': '<(DEPTH)/xcodebuild', 5856 'SYMROOT': '<(DEPTH)/xcodebuild',
5857 }, 5857 },
5858 } 5858 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698