Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 86053005: [NaCl SDK] Fix "make debug" and "make run" on Mac. (Closed)

Created:
7 years ago by binji
Modified:
7 years ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Fix "make debug" and "make run" on Mac. There were a couple of issues here: * make doesn't support spaces, so you have to escape them. * xterm doesn't exist on mac, use osascript to create a new Terminal window instead. Also, use the correct basename/default paths for Chrome on each platform. BUG=322549 R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238245

Patch Set 1 #

Patch Set 2 : add default paths, basenames #

Total comments: 2

Patch Set 3 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -23 lines) Patch
M native_client_sdk/src/tools/common.mk View 3 chunks +13 lines, -7 lines 0 comments Download
M native_client_sdk/src/tools/getos.py View 1 2 4 chunks +23 lines, -10 lines 0 comments Download
M native_client_sdk/src/tools/run.py View 1 chunk +6 lines, -2 lines 0 comments Download
M native_client_sdk/src/tools/tests/getos_test.py View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
7 years ago (2013-11-26 02:43:12 UTC) #1
binji
ping
7 years ago (2013-12-02 21:57:14 UTC) #2
Sam Clegg
lgtm https://codereview.chromium.org/86053005/diff/20001/native_client_sdk/src/tools/getos.py File native_client_sdk/src/tools/getos.py (right): https://codereview.chromium.org/86053005/diff/20001/native_client_sdk/src/tools/getos.py#newcode32 native_client_sdk/src/tools/getos.py:32: } Isn't this information duplicated here. Also, I'm ...
7 years ago (2013-12-02 22:46:50 UTC) #3
binji
https://codereview.chromium.org/86053005/diff/20001/native_client_sdk/src/tools/getos.py File native_client_sdk/src/tools/getos.py (right): https://codereview.chromium.org/86053005/diff/20001/native_client_sdk/src/tools/getos.py#newcode32 native_client_sdk/src/tools/getos.py:32: } On 2013/12/02 22:46:50, Sam Clegg wrote: > Isn't ...
7 years ago (2013-12-03 00:33:58 UTC) #4
binji
7 years ago (2013-12-03 00:35:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r238245 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698