Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: native_client_sdk/src/tools/run.py

Issue 86053005: [NaCl SDK] Fix "make debug" and "make run" on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/tools/getos.py ('k') | native_client_sdk/src/tools/tests/getos_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/tools/run.py
diff --git a/native_client_sdk/src/tools/run.py b/native_client_sdk/src/tools/run.py
index e2af3595813fcc9d4967c6f822b1c2c9c7a3eaf7..fb99b6d34a554656033a152b727e5f11c9aa39d0 100755
--- a/native_client_sdk/src/tools/run.py
+++ b/native_client_sdk/src/tools/run.py
@@ -67,11 +67,15 @@ def main(args):
# If any debug args are passed in, assume we want to debug
if options.debug:
- if getos.GetPlatform() != 'win':
+ if getos.GetPlatform() == 'linux':
cmd = ['xterm', '-title', 'NaCl Debugger', '-e']
+ cmd += options.debug
+ elif getos.GetPlatform() == 'mac':
+ cmd = ['osascript', '-e',
+ 'tell application "Terminal" to do script "%s"' %
+ ' '.join(r'\"%s\"' % x for x in options.debug)]
else:
cmd = []
- cmd += options.debug
print 'Starting debugger: ' + ' '.join(cmd)
debug_process = subprocess.Popen(cmd, env=env)
else:
« no previous file with comments | « native_client_sdk/src/tools/getos.py ('k') | native_client_sdk/src/tools/tests/getos_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698