Issue 860463002: Merging into M41 branch 2272.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 860463002: Merging into M41 branch 2272. (Closed)

Created:
5 years, 11 months ago by penny

Modified:
5 years, 11 months ago

Reviewers:

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merging into M41 branch 2272. Fix for 'New Folder' is not getting added to chrome://bookmarks/ through 'Organize' menu after adding 'addPage' When we do add page then new node is added, but that node in not yet commited, and have id as 'new', so we should not consider as the selected item. Changes added so that when the entry is not commited, it should not be considered for calculating the nextIndex value. BUG=447960 Review URL: https://codereview.chromium.org/835973004 Cr-Commit-Position: refs/heads/master@{#311200} (cherry picked from commit c69c7002fee94d11a45a5eff779ac93a0da6b048) Committed: https://chromium.googlesource.com/chromium/src/+/c2b44c018d1d4f83d5c32f7aca76cc24f3b72dee

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/bookmark_manager/js/main.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

penny

5 years, 11 months ago (2015-01-17 07:36:24 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2b44c018d1d4f83d5c32f7aca76cc24f3b72dee.

Expand Messages | Collapse Messages