Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 835973004: Fix for 'New Folder' is not getting added to chrome://bookmarks/ through 'Organize' menu after addi… (Closed)

Created:
5 years, 11 months ago by Deepak
Modified:
5 years, 11 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for 'New Folder' is not getting added to chrome://bookmarks/ through 'Organize' menu after adding 'addPage' When we do add page then new node is added, but that node in not yet commited, and have id as 'new', so we should not consider as the selected item. Changes added so that when the entry is not commited, it should not be considered for calculating the nextIndex value. BUG=447960 Committed: https://crrev.com/c69c7002fee94d11a45a5eff779ac93a0da6b048 Cr-Commit-Position: refs/heads/master@{#311200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
PTAL.
5 years, 11 months ago (2015-01-12 13:43:01 UTC) #2
Nikita (slow)
lgtm
5 years, 11 months ago (2015-01-12 14:40:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835973004/1
5 years, 11 months ago (2015-01-13 02:41:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 03:37:42 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 03:38:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c69c7002fee94d11a45a5eff779ac93a0da6b048
Cr-Commit-Position: refs/heads/master@{#311200}

Powered by Google App Engine
This is Rietveld 408576698