Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 860453002: Move OpenProcessHandleWithAccess to Process::OpenWithAccess. (Closed)

Created:
5 years, 11 months ago by rvargas (doing something else)
Modified:
5 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico
CC:
chromium-reviews, kalyank, erikwright+watch_chromium.org, sadrul, jam, stuartmorgan+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move OpenProcessHandleWithAccess to Process::OpenWithAccess. This removes another source of raw process handles. BUG=417532 Committed: https://crrev.com/17a407d8909846afcb50a6e29bc3686876fbfa03 Cr-Commit-Position: refs/heads/master@{#312919}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Review feedback #

Patch Set 3 : Fix for Mac #

Patch Set 4 : Add ServiceProcessControlBrowserTest.Setup again #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -174 lines) Patch
M ash/test/test_metro_viewer_process_host.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M base/process/process.h View 1 chunk +6 lines, -0 lines 0 comments Download
M base/process/process_handle.h View 1 chunk +0 lines, -6 lines 0 comments Download
M base/process/process_handle_posix.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M base/process/process_handle_win.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M base/process/process_iterator.h View 2 chunks +0 lines, -37 lines 0 comments Download
M base/process/process_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_process_finder_win.cc View 1 2 chunks +1 line, -40 lines 1 comment Download
M chrome/browser/plugins/plugin_observer.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/browser/service_process/service_process_control_browsertest.cc View 1 2 3 6 chunks +20 lines, -16 lines 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/nacl/broker/nacl_broker_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 3 chunks +13 lines, -15 lines 0 comments Download
M components/nacl/common/nacl_debug_exception_handler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/common/nacl_debug_exception_handler_win.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
rvargas (doing something else)
5 years, 11 months ago (2015-01-21 01:21:11 UTC) #3
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/860453002/diff/20001/base/process/process_win.cc File base/process/process_win.cc (right): https://codereview.chromium.org/860453002/diff/20001/base/process/process_win.cc#newcode58 base/process/process_win.cc:58: return Process(handle); return Process(::OpenProcess(desired_access, FALSE, pid)); or even return ...
5 years, 11 months ago (2015-01-22 00:38:32 UTC) #4
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/860453002/diff/20001/chrome/browser/chrome_process_finder_win.cc File chrome/browser/chrome_process_finder_win.cc (right): https://codereview.chromium.org/860453002/diff/20001/chrome/browser/chrome_process_finder_win.cc#newcode115 chrome/browser/chrome_process_finder_win.cc:115: #if !defined(USE_AURA) I believe this code is dead so ...
5 years, 11 months ago (2015-01-22 00:43:22 UTC) #5
cpu_(ooo_6.6-7.5)
rest looks fine. https://codereview.chromium.org/860453002/diff/20001/chrome/browser/plugins/plugin_observer.cc File chrome/browser/plugins/plugin_observer.cc (right): https://codereview.chromium.org/860453002/diff/20001/chrome/browser/plugins/plugin_observer.cc#newcode297 chrome/browser/plugins/plugin_observer.cc:297: base::Process plugin = plugin_process rather than ...
5 years, 11 months ago (2015-01-22 01:09:10 UTC) #6
rvargas (doing something else)
Thanks. https://codereview.chromium.org/860453002/diff/20001/base/process/process_win.cc File base/process/process_win.cc (right): https://codereview.chromium.org/860453002/diff/20001/base/process/process_win.cc#newcode58 base/process/process_win.cc:58: return Process(handle); On 2015/01/22 00:38:32, cpu wrote: > ...
5 years, 11 months ago (2015-01-22 01:51:17 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-22 01:55:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860453002/40001
5 years, 11 months ago (2015-01-22 02:00:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/649)
5 years, 11 months ago (2015-01-22 02:10:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860453002/40001
5 years, 11 months ago (2015-01-22 02:38:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25666)
5 years, 11 months ago (2015-01-22 04:25:24 UTC) #16
rvargas (doing something else)
I had to make some changes to service_process_control_browsertest.cc. Do you mind taking another look at ...
5 years, 11 months ago (2015-01-23 03:10:15 UTC) #17
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-23 19:32:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860453002/80001
5 years, 11 months ago (2015-01-23 20:12:04 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 11 months ago (2015-01-23 20:37:14 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/17a407d8909846afcb50a6e29bc3686876fbfa03 Cr-Commit-Position: refs/heads/master@{#312919}
5 years, 11 months ago (2015-01-23 20:37:55 UTC) #22
Nico
https://codereview.chromium.org/860453002/diff/80001/chrome/browser/chrome_process_finder_win.cc File chrome/browser/chrome_process_finder_win.cc (left): https://codereview.chromium.org/860453002/diff/80001/chrome/browser/chrome_process_finder_win.cc#oldcode152 chrome/browser/chrome_process_finder_win.cc:152: #endif Did you delete this block intentionally? It looks ...
5 years, 5 months ago (2015-07-26 02:54:09 UTC) #24
Nico
5 years, 5 months ago (2015-07-26 02:54:39 UTC) #25
Message was sent while issue was closed. 
On 2015/07/26 02:54:09, Nico (vacation Mon Jul 27) wrote:
>
https://codereview.chromium.org/860453002/diff/80001/chrome/browser/chrome_pr...
> File chrome/browser/chrome_process_finder_win.cc (left):
> 
>
https://codereview.chromium.org/860453002/diff/80001/chrome/browser/chrome_pr...
> chrome/browser/chrome_process_finder_win.cc:152: #endif
> Did you delete this block intentionally? It looks unrelated to the CL
> description to me.

Ah, cpu apparently asked for that and the CL description didn't get updated.
Nevermind.

Powered by Google App Engine
This is Rietveld 408576698