Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 8603009: Add a fetcher class to fetch an OAuth2 login scope token from ClientLogin credentials. (Closed)

Created:
9 years, 1 month ago by Munjal (Google)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., asargent_no_longer_on_chrome, sail
Visibility:
Public.

Description

Add a fetcher class to fetch an OAuth2 login scope token from ClientLogin credentials. Full set of tests. Note that this is not yet hooked up to anything; I am doing the work in peices.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+862 lines, -0 lines) Patch
A chrome/browser/net/gaia/oauth2_login_token_consumer.h View 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/net/gaia/oauth2_login_token_fetcher.h View 1 2 3 4 5 1 chunk +112 lines, -0 lines 0 comments Download
A chrome/browser/net/gaia/oauth2_login_token_fetcher.cc View 1 2 3 4 5 1 chunk +331 lines, -0 lines 0 comments Download
A chrome/browser/net/gaia/oauth2_login_token_fetcher_unittest.cc View 1 chunk +342 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.h View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_urls.cc View 1 2 3 4 3 chunks +36 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/google_service_auth_error.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Munjal (Google)
9 years, 1 month ago (2011-11-19 08:00:14 UTC) #1
Rick Campbell
I note that there are a number of lint errors showing in the code review ...
9 years, 1 month ago (2011-11-21 21:51:46 UTC) #2
Munjal (Google)
9 years, 1 month ago (2011-11-21 22:14:57 UTC) #3
Regarding the lint warnings, the ones that say no newline at the end of the file
seem to be either a false alarm of due to Windows eol style. I will make sure it
is not the latter. Fixed others.

Regarding the comment about doing this in gaia_auth_fetcher, that class is
already quite complicated. I thought it is worth adding a simple fetcher
abstraction for OAuth2 flows and then we can embed them wherever we want. If we
want ot embed them in GaiaAuthFetcher that is possible too. But the separate
fetcher abstractions for details fo request sending and response parsing seems
better.

Powered by Google App Engine
This is Rietveld 408576698