Add a fetcher class to fetch an OAuth2 login scope token from ClientLogin credentials.

chrome/browser/net/gaia/oauth2_login_token_fetcher_unittest.cc

Index: chrome/browser/net/gaia/oauth2_login_token_fetcher_unittest.cc
===================================================================
--- chrome/browser/net/gaia/oauth2_login_token_fetcher_unittest.cc	(revision 0)
+++ chrome/browser/net/gaia/oauth2_login_token_fetcher_unittest.cc	(revision 0)
@@ -0,0 +1,342 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// A complete set of unit tests for OAuth2LoginTokenFetcher.
+
+#include <string>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop.h"
+#include "chrome/browser/net/gaia/oauth2_login_token_consumer.h"
+#include "chrome/browser/net/gaia/oauth2_login_token_fetcher.h"
+#include "chrome/common/net/gaia/gaia_urls.h"
+#include "chrome/common/net/gaia/google_service_auth_error.h"
+#include "chrome/common/net/http_return.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/common/url_fetcher.h"
+#include "content/public/common/url_fetcher_delegate.h"
+#include "content/public/common/url_fetcher_factory.h"
+#include "content/test/test_browser_thread.h"
+#include "content/test/test_url_fetcher_factory.h"
+#include "googleurl/src/gurl.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_status.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using content::BrowserThread;
+using content::URLFetcher;
+using content::URLFetcherDelegate;
+using content::URLFetcherFactory;
+using net::ResponseCookies;
+using net::URLRequestStatus;
+using testing::_;
+using testing::Return;
+
+namespace {
+static const char kValidSetCookieHeader[] =
+    "oauth_code=test-code; Path=/test; Secure; HttpOnly";
+static const char kSetCookieHeaderMissingSecure[] =
+    "oauth_code=test-code; Path=/test; HttpOnly";
+static const char kSetCookieHeaderMissingHttpOnly[] =
+    "oauth_code=test-code; Path=/test; Secure";
+static const char kSetCookieHeaderMissingOAuthCode[] =
+    "Path=/test; Secure; HttpOnly";
+static const char kValidTokenResponse[] =
+    "{"
+    "  \"refresh_token\": \"rt1\","
+    "  \"access_token\": \"at1\""
+    "}";
+static const char kTokenResponseNoRefreshToken[] =
+    "{"
+    "  \"access_token\": \"at1\""
+    "}";
+static const char kTokenResponseNoAccessToken[] =
+    "{"
+    "  \"refresh_token\": \"rt1\""
+    "}";
+}
+
+class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
+                              public URLFetcherFactory {
+public:
+  MockUrlFetcherFactory()
+      : ScopedURLFetcherFactory(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
+  }
+  virtual ~MockUrlFetcherFactory() {}
+
+  MOCK_METHOD4(
+      CreateURLFetcher,
+      URLFetcher* (int id,
+                   const GURL& url,
+                   URLFetcher::RequestType request_type,
+                   URLFetcherDelegate* d));
+};
+
+class MockOAuth2LoginTokenConsumer : public OAuth2LoginTokenConsumer {
+ public:
+  MockOAuth2LoginTokenConsumer() {}
+  ~MockOAuth2LoginTokenConsumer() {}
+
+  MOCK_METHOD2(OnGetTokenSuccess, void(const std::string& refresh_token,
+                                       const std::string& access_token));
+  MOCK_METHOD1(OnGetTokenFailure,
+               void(const GoogleServiceAuthError& error));
+};
+
+class OAuth2LoginTokenFetcherTest : public testing::Test {
+ public:
+  OAuth2LoginTokenFetcherTest()
+    : ui_thread_(BrowserThread::UI, &message_loop_),
+      fetcher_(&consumer_, profile_.GetRequestContext(), "test") {
+  }
+
+  virtual ~OAuth2LoginTokenFetcherTest() { }
+
+  virtual TestURLFetcher* SetupGetAuthCode(
+      bool fetch_succeeds, int response_code, const std::string& cookie) {
+    GURL url(GaiaUrls::GetInstance()->client_login_to_oauth2_url());
+    TestURLFetcher* url_fetcher = new TestURLFetcher(0, url, &fetcher_);
+    URLRequestStatus::Status status =
+        fetch_succeeds ? URLRequestStatus::SUCCESS : URLRequestStatus::FAILED;
+    url_fetcher->set_status(URLRequestStatus(status, 0));
+
+    if (response_code != 0)
+      url_fetcher->set_response_code(response_code);
+
+    if (!cookie.empty()) {
+      ResponseCookies cookies;
+      cookies.push_back(cookie);
+      url_fetcher->set_cookies(cookies);
+    }
+
+    EXPECT_CALL(factory_, CreateURLFetcher(_, url, _, _))
+        .WillOnce(Return(url_fetcher));
+    return url_fetcher;
+  }
+
+  virtual TestURLFetcher* SetupGetTokenPair(
+      bool fetch_succeeds, int response_code, const std::string& body) {
+    GURL url(GaiaUrls::GetInstance()->oauth2_token_url());
+    TestURLFetcher* url_fetcher = new TestURLFetcher(0, url, &fetcher_);
+    URLRequestStatus::Status status =
+        fetch_succeeds ? URLRequestStatus::SUCCESS : URLRequestStatus::FAILED;
+    url_fetcher->set_status(URLRequestStatus(status, 0));
+
+    if (response_code != 0)
+      url_fetcher->set_response_code(response_code);
+
+    if (!body.empty())
+      url_fetcher->SetResponseString(body);
+
+    EXPECT_CALL(factory_, CreateURLFetcher(_, url, _, _))
+        .WillOnce(Return(url_fetcher));
+    return url_fetcher;
+  }
+
+ protected:
+  MessageLoop message_loop_;
+  content::TestBrowserThread ui_thread_;
+  MockUrlFetcherFactory factory_;
+  MockOAuth2LoginTokenConsumer consumer_;
+  TestingProfile profile_;
+  OAuth2LoginTokenFetcher fetcher_;
+};
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetAuthCodeRequestFailure) {
+  TestURLFetcher* url_fetcher = SetupGetAuthCode(false, 0, "");
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetAuthCodeResponseCodeFailure) {
+  TestURLFetcher* url_fetcher = SetupGetAuthCode(true, RC_FORBIDDEN, "");
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetAuthCodeResponseMissingSecure) {
+  TestURLFetcher* url_fetcher = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kSetCookieHeaderMissingSecure);
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetAuthCodeResponseMissingHttpOnly) {
+  TestURLFetcher* url_fetcher = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kSetCookieHeaderMissingHttpOnly);
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetAuthCodeResponseMissingOAuthCode) {
+  TestURLFetcher* url_fetcher = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kSetCookieHeaderMissingOAuthCode);
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetTokenPairRequestFailure) {
+  TestURLFetcher* url_fetcher1 = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kValidSetCookieHeader);
+  TestURLFetcher* url_fetcher2 = SetupGetTokenPair(false, 0, "");
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher1);
+  fetcher_.OnURLFetchComplete(url_fetcher2);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetTokenPairResponseCodeFailure) {
+  TestURLFetcher* url_fetcher1 = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kValidSetCookieHeader);
+  TestURLFetcher* url_fetcher2 = SetupGetTokenPair(true, RC_FORBIDDEN, "");
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher1);
+  fetcher_.OnURLFetchComplete(url_fetcher2);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetTokenPairResponseMissingRefreshToken) {
+  TestURLFetcher* url_fetcher1 = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kValidSetCookieHeader);
+  TestURLFetcher* url_fetcher2 = SetupGetTokenPair(
+      true, RC_REQUEST_OK, kTokenResponseNoRefreshToken);
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher1);
+  fetcher_.OnURLFetchComplete(url_fetcher2);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, GetTokenPairResponseMissingAccessToken) {
+  TestURLFetcher* url_fetcher1 = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kValidSetCookieHeader);
+  TestURLFetcher* url_fetcher2 = SetupGetTokenPair(
+      true, RC_REQUEST_OK, kTokenResponseNoAccessToken);
+  EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher1);
+  fetcher_.OnURLFetchComplete(url_fetcher2);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, Success) {
+  TestURLFetcher* url_fetcher1 = SetupGetAuthCode(
+      true, RC_REQUEST_OK, kValidSetCookieHeader);
+  TestURLFetcher* url_fetcher2 = SetupGetTokenPair(
+      true, RC_REQUEST_OK, kValidTokenResponse);
+  EXPECT_CALL(consumer_, OnGetTokenSuccess("rt1", "at1")).Times(1);
+  fetcher_.Start("auth_token");
+  fetcher_.OnURLFetchComplete(url_fetcher1);
+  fetcher_.OnURLFetchComplete(url_fetcher2);
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, ParseGetAuthCodeResponse) {
+  {  // No cookies.
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+
+    std::string auth_code;
+    EXPECT_FALSE(OAuth2LoginTokenFetcher::ParseGetAuthCodeResponse(
+        &url_fetcher, &auth_code));
+    EXPECT_TRUE(auth_code.empty());
+  }
+  {  // Some cookies, nothing appropriate.
+    ResponseCookies cookies;
+    cookies.push_back("foo");
+    cookies.push_back("oauth_code=foo");
+    cookies.push_back(kSetCookieHeaderMissingOAuthCode);
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.set_cookies(cookies);
+
+    std::string auth_code;
+    EXPECT_FALSE(OAuth2LoginTokenFetcher::ParseGetAuthCodeResponse(
+        &url_fetcher, &auth_code));
+    EXPECT_TRUE(auth_code.empty());
+  }
+  {  // Single cookie: a valid one.
+    ResponseCookies cookies;
+    cookies.push_back(kValidSetCookieHeader);
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.set_cookies(cookies);
+
+    std::string auth_code;
+    EXPECT_TRUE(OAuth2LoginTokenFetcher::ParseGetAuthCodeResponse(
+        &url_fetcher, &auth_code));
+    EXPECT_EQ("test-code", auth_code);
+  }
+  {  // Some cookies: with a valid one.
+    ResponseCookies cookies;
+    cookies.push_back(kSetCookieHeaderMissingSecure);
+    cookies.push_back(kSetCookieHeaderMissingHttpOnly);
+    cookies.push_back(kSetCookieHeaderMissingOAuthCode);
+    cookies.push_back(kValidSetCookieHeader);
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.set_cookies(cookies);
+
+    std::string auth_code;
+    EXPECT_TRUE(OAuth2LoginTokenFetcher::ParseGetAuthCodeResponse(
+        &url_fetcher, &auth_code));
+    EXPECT_EQ("test-code", auth_code);
+  }
+}
+
+TEST_F(OAuth2LoginTokenFetcherTest, ParseGetTokenPairResponse) {
+  {  // No body.
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+
+    std::string rt;
+    std::string at;
+    EXPECT_FALSE(OAuth2LoginTokenFetcher::ParseGetTokenPairResponse(
+        &url_fetcher, &rt, &at));
+    EXPECT_TRUE(rt.empty());
+    EXPECT_TRUE(at.empty());
+  }
+  {  // Bad json.
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.SetResponseString("foo");
+
+    std::string rt;
+    std::string at;
+    EXPECT_FALSE(OAuth2LoginTokenFetcher::ParseGetTokenPairResponse(
+        &url_fetcher, &rt, &at));
+    EXPECT_TRUE(rt.empty());
+    EXPECT_TRUE(at.empty());
+  }
+  {  // Valid json: refresh token missing.
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.SetResponseString(kTokenResponseNoRefreshToken);
+
+    std::string rt;
+    std::string at;
+    EXPECT_FALSE(OAuth2LoginTokenFetcher::ParseGetTokenPairResponse(
+        &url_fetcher, &rt, &at));
+    EXPECT_TRUE(rt.empty());
+    EXPECT_TRUE(at.empty());
+  }
+  {  // Valid json: access token missing.
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.SetResponseString(kTokenResponseNoAccessToken);
+
+    std::string rt;
+    std::string at;
+    EXPECT_FALSE(OAuth2LoginTokenFetcher::ParseGetTokenPairResponse(
+        &url_fetcher, &rt, &at));
+    EXPECT_TRUE(rt.empty());
+    EXPECT_TRUE(at.empty());
+  }
+  {  // Valid json: all good.
+    TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
+    url_fetcher.SetResponseString(kValidTokenResponse);
+
+    std::string rt;
+    std::string at;
+    EXPECT_TRUE(OAuth2LoginTokenFetcher::ParseGetTokenPairResponse(
+        &url_fetcher, &rt, &at));
+    EXPECT_EQ("rt1", rt);
+    EXPECT_EQ("at1", at);
+  }
+}