Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits

Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits

setIgnoreViewportTagScaleLimits copies the default limits into the UA
constraints. This was happening before the defualt limits were set during
initialization so it was clamping page scale at [1,1].

BUG=453377
Committed: https://crrev.com/ebbcc53e21fbfe15a76fa7fbf6d14c84095880ee
Cr-Commit-Position: refs/heads/master@{#314668}

[bokan, 2015-02-04 06:38:09]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2015-02-04 06:38:10]

You were right, it was the ordering with setting the defaults.

AFAICT, there's no unit tests on render_view_impl and this can't be tested via
layout tests since we need to control the value of the force_enable_zoom before
the page loads. I figure a browser_test is probably overkill, let me know if
you'd like me to add one.

[aelias_OOO_until_Jul13, 2015-02-04 08:10:18]

aelias@chromium.org changed reviewers:
+ sievers@chromium.org

[aelias_OOO_until_Jul13, 2015-02-04 08:11:57]

lgtm, sounds reasonable.  Adding sievers@ for OWNERS.

[no sievers, 2015-02-04 19:30:01]

lgtm

https://codereview.chromium.org/860283005/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/860283005/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:1072: 
you probably want to add a test, or at least a comment, or it's not unlikely
that it will break again (it's not obvious that order matters).

[bokan, 2015-02-04 20:15:07]

New patchsets have been uploaded after l-g-t-m from
aelias@chromium.org,sievers@chromium.org

[bokan, 2015-02-04 20:16:35]

Added a comment (since test in this case is hard, see above).

[bokan, 2015-02-04 20:17:00]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-02-04 20:18:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/860283005/20001

[commit-bot: I haz the power, 2015-02-04 21:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:44:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bokan, 2015-02-04 21:44:59]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:46:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/860283005/20001

[commit-bot: I haz the power, 2015-02-04 22:50:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-04 22:51:04]

Patchset 2 (id:??) landed as
https://crrev.com/ebbcc53e21fbfe15a76fa7fbf6d14c84095880ee
Cr-Commit-Position: refs/heads/master@{#314668}

[dcheng, 2015-02-05 02:33:50]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/897173003/ by dcheng@chromium.org.

The reason for reverting is: Speculatively reverting to try to fix broken layout
tests in Blink:
compositing/iframes/iframe-composited-scrolling-hide-and-show.html
compositing/iframes/overlapped-iframe-iframe.html
svg/as-border-image/svg-as-border-image-2.html
and more..

[dcheng, 2015-02-05 02:34:41]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-02-05 02:34:42]

Example of a failing run:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28r...

Unfortunately, I can't repro locally, so I'm guessing...