Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 860283005: Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1052 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 settings->setSelectionIncludesAltImageText(true); 1063 settings->setSelectionIncludesAltImageText(true);
1064 1064
1065 settings->setV8CacheOptions( 1065 settings->setV8CacheOptions(
1066 static_cast<WebSettings::V8CacheOptions>(prefs.v8_cache_options)); 1066 static_cast<WebSettings::V8CacheOptions>(prefs.v8_cache_options));
1067 1067
1068 settings->setV8ScriptStreamingEnabled(prefs.v8_script_streaming_enabled); 1068 settings->setV8ScriptStreamingEnabled(prefs.v8_script_streaming_enabled);
1069 settings->setV8ScriptStreamingMode( 1069 settings->setV8ScriptStreamingMode(
1070 static_cast<WebSettings::V8ScriptStreamingMode>( 1070 static_cast<WebSettings::V8ScriptStreamingMode>(
1071 prefs.v8_script_streaming_mode)); 1071 prefs.v8_script_streaming_mode));
1072 1072
1073 // Needs to happen before setIgnoreVIewportTagScaleLimits below.
1074 web_view->setDefaultPageScaleLimits(
1075 prefs.default_minimum_page_scale_factor,
1076 prefs.default_maximum_page_scale_factor);
1077
1073 #if defined(OS_ANDROID) 1078 #if defined(OS_ANDROID)
1074 settings->setAllowCustomScrollbarInMainFrame(false); 1079 settings->setAllowCustomScrollbarInMainFrame(false);
1075 settings->setTextAutosizingEnabled(prefs.text_autosizing_enabled); 1080 settings->setTextAutosizingEnabled(prefs.text_autosizing_enabled);
1076 settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor); 1081 settings->setAccessibilityFontScaleFactor(prefs.font_scale_factor);
1077 settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment); 1082 settings->setDeviceScaleAdjustment(prefs.device_scale_adjustment);
1078 settings->setFullscreenSupported(prefs.fullscreen_supported); 1083 settings->setFullscreenSupported(prefs.fullscreen_supported);
1079 web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom); 1084 web_view->setIgnoreViewportTagScaleLimits(prefs.force_enable_zoom);
1080 settings->setAutoZoomFocusedNodeToLegibleScale(true); 1085 settings->setAutoZoomFocusedNodeToLegibleScale(true);
1081 settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled); 1086 settings->setDoubleTapToZoomEnabled(prefs.double_tap_to_zoom_enabled);
1082 settings->setMediaControlsOverlayPlayButtonEnabled(true); 1087 settings->setMediaControlsOverlayPlayButtonEnabled(true);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 1129
1125 settings->setPinchOverlayScrollbarThickness( 1130 settings->setPinchOverlayScrollbarThickness(
1126 prefs.pinch_overlay_scrollbar_thickness); 1131 prefs.pinch_overlay_scrollbar_thickness);
1127 settings->setRubberBandingOnCompositorThread( 1132 settings->setRubberBandingOnCompositorThread(
1128 prefs.rubber_banding_on_compositor_thread); 1133 prefs.rubber_banding_on_compositor_thread);
1129 settings->setUseSolidColorScrollbars(prefs.use_solid_color_scrollbars); 1134 settings->setUseSolidColorScrollbars(prefs.use_solid_color_scrollbars);
1130 1135
1131 #if defined(OS_WIN) 1136 #if defined(OS_WIN)
1132 settings->setShowContextMenuOnMouseUp(true); 1137 settings->setShowContextMenuOnMouseUp(true);
1133 #endif 1138 #endif
1134
1135 web_view->setDefaultPageScaleLimits(
1136 prefs.default_minimum_page_scale_factor,
1137 prefs.default_maximum_page_scale_factor);
1138 } 1139 }
1139 1140
1140 /*static*/ 1141 /*static*/
1141 RenderViewImpl* RenderViewImpl::Create(const ViewMsg_New_Params& params, 1142 RenderViewImpl* RenderViewImpl::Create(const ViewMsg_New_Params& params,
1142 CompositorDependencies* compositor_deps, 1143 CompositorDependencies* compositor_deps,
1143 bool was_created_by_renderer) { 1144 bool was_created_by_renderer) {
1144 DCHECK(params.view_id != MSG_ROUTING_NONE); 1145 DCHECK(params.view_id != MSG_ROUTING_NONE);
1145 RenderViewImpl* render_view = NULL; 1146 RenderViewImpl* render_view = NULL;
1146 if (g_create_render_view_impl) 1147 if (g_create_render_view_impl)
1147 render_view = g_create_render_view_impl(params); 1148 render_view = g_create_render_view_impl(params);
(...skipping 2943 matching lines...) Expand 10 before | Expand all | Expand 10 after
4091 std::vector<gfx::Size> sizes; 4092 std::vector<gfx::Size> sizes;
4092 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes); 4093 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
4093 if (!url.isEmpty()) 4094 if (!url.isEmpty())
4094 urls.push_back( 4095 urls.push_back(
4095 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes)); 4096 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
4096 } 4097 }
4097 SendUpdateFaviconURL(urls); 4098 SendUpdateFaviconURL(urls);
4098 } 4099 }
4099 4100
4100 } // namespace content 4101 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698