Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 860173003: [VS Addin] Disable PPAPI linking test except on VS2012 (Closed)

Created:
5 years, 11 months ago by Sam Clegg
Modified:
5 years, 9 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VS Addin] Disable PPAPI linking test except on VS2012 The pre-compiled libraries (specifically ppapi_cpp.lib) that we ship are only compiled with VS2012 so this test will fail on 2010 due to library incompatability. These tests used to pass with pepper_36 since at that point the SDK builders were still using 2010. BUG= R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1581

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : use Assert.Inconclusive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sam Clegg
5 years, 10 months ago (2015-02-24 00:32:19 UTC) #2
binji
lgtm https://codereview.chromium.org/860173003/diff/20001/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs File visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs (right): https://codereview.chromium.org/860173003/diff/20001/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs#newcode70 visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs:70: return; Isn't this what Assert.Inconclusive() is for?
5 years, 10 months ago (2015-02-24 00:35:05 UTC) #3
Sam Clegg
On 2015/02/24 00:35:05, binji wrote: > lgtm > > https://codereview.chromium.org/860173003/diff/20001/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs > File visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs (right): > ...
5 years, 10 months ago (2015-02-24 01:57:30 UTC) #4
Sam Clegg
5 years, 9 months ago (2015-02-26 23:20:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 1581 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698