Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs

Issue 860173003: [VS Addin] Disable PPAPI linking test except on VS2012 (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: use Assert.Inconclusive Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
diff --git a/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs b/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
index 629ce3efe767498f41584ae4690033802d30346c..3b7d03d06f7e43d985baf18b4913ca0cd6d38ed6 100644
--- a/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
+++ b/visual_studio/NativeClientVSAddIn/UnitTests/CompileTest.cs
@@ -61,6 +61,14 @@ namespace UnitTests
[TestMethod]
public void CheckPepperCompile()
{
+ if (!TestUtilities.IsVS2012())
+ {
+ // The pre-compiled libraries in the SDK (specifically
+ // ppapi_cpp.lib) are not linkable except with 2012 so
+ // this test will always fail with link errors under 2010
+ // or any other Visual Studio version.
+ Assert.Inconclusive();
+ }
CheckCompile(Strings.PepperPlatformName);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698