Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 860163002: Ensure tags are fetched when generating the V8 version. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev, hinoka
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure tags are fetched when generating the V8 version. This is needed so that version generation works after bot_update fetched v8 in a chromium checkout. TBR=tandrii@chromium.org BUG=chromium:446166 LOG=n Committed: https://crrev.com/ea6831e9de62ceade14b7baeb7d57c74a30a1f38 Cr-Commit-Position: refs/heads/master@{#26177}

Patch Set 1 #

Patch Set 2 : Fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/generate_version.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-20 22:37:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/860163002/20001
5 years, 11 months ago (2015-01-21 07:58:40 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 07:59:54 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ea6831e9de62ceade14b7baeb7d57c74a30a1f38 Cr-Commit-Position: refs/heads/master@{#26177}
5 years, 11 months ago (2015-01-21 08:00:32 UTC) #6
tandrii(chromium)
5 years, 11 months ago (2015-01-21 12:08:47 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698