build/generate_version.py - Issue 860163002: Ensure tags are fetched when generating the V8 version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/generate_version.py

Issue 860163002: Ensure tags are fetched when generating the V8 version. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix win Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/generate_version.py

diff --git a/build/generate_version.py b/build/generate_version.py

index 2d4c40dba3e8de5dc22bee7032515648d2ddfd09..785284281f09ba1b0b71011b083cb213cc1634b7 100755

--- a/build/generate_version.py

+++ b/build/generate_version.py

@@ -28,6 +28,11 @@ VERSION_GEN_CC = os.path.join(CWD, "src", "version_gen.cc")

def generate_version_file():

+ # Make sure the tags are fetched.

+ subprocess.check_output(

+ "git fetch origin +refs/tags/*:refs/tags/*",

+ shell=True,

+ cwd=CWD)

tag = subprocess.check_output(

"git describe --tags",

shell=True,

« no previous file with comments | « no previous file | no next file » | no next file with comments »