Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: content/browser/download/download_query_unittest.cc

Issue 8601012: DownloadQuery filters and sorts DownloadItems. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Callbacks Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_query_unittest.cc
diff --git a/content/browser/download/download_query_unittest.cc b/content/browser/download/download_query_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b9ae67a047fe4c956ec2cb59a17935261b6a37f1
--- /dev/null
+++ b/content/browser/download/download_query_unittest.cc
@@ -0,0 +1,125 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/bind.h"
+#include "base/file_path.h"
+#include "base/logging.h"
+#include "base/stl_util.h"
+#include "content/browser/download/download_query.h"
+#include "content/browser/download/mock_download_item.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#include "base/utf_string_conversions.h"
+
+using ::testing::Return;
+using ::testing::ReturnRef;
+typedef DownloadQuery::DownloadVector DownloadVector;
+
+namespace {
+bool OnlyEvenIds(const DownloadItem& item) {
+ return item.GetId() % 2 == 0;
+}
+}
+
+class DownloadQueryTest : public testing::Test {
+ public:
+ DownloadQueryTest() {}
+ virtual ~DownloadQueryTest() {}
+ virtual void TearDown() {
+ STLDeleteElements(&mocks_);
+ }
+ void CreateMocks(int count) {
+ for (int i = 0; i < count; ++i) {
+ mocks_.push_back(new MockDownloadItem());
+ all_items_.push_back(mocks_[i]);
+ }
+ }
+ MockDownloadItem& mock(int index) { return *mocks_[index]; }
+ DownloadQuery* query() { return &query_; }
+ DownloadVector* all_items() { return &all_items_; }
+ DownloadVector* results() { return &results_; }
+ void Search() {
+ query()->Search(all_items_.begin(), all_items_.end(), &results_);
+ }
+
+ private:
+ std::vector<MockDownloadItem*> mocks_;
+ DownloadQuery query_;
+ DownloadVector all_items_;
+ DownloadVector results_;
+
+ DISALLOW_COPY_AND_ASSIGN(DownloadQueryTest);
+};
+
+TEST_F(DownloadQueryTest, EmptyQueryNoItems) {
+ Search();
+ EXPECT_EQ(0U, results()->size());
+}
+
+TEST_F(DownloadQueryTest, EmptyQuerySomeItems) {
+ CreateMocks(3);
+ Search();
+ EXPECT_EQ(3U, results()->size());
+}
+
+TEST_F(DownloadQueryTest, FilterBytesReceived) {
+ CreateMocks(2);
+ EXPECT_CALL(mock(0), GetReceivedBytes()).WillOnce(Return(0));
+ EXPECT_CALL(mock(1), GetReceivedBytes()).WillOnce(Return(1));
+ query()->Filter(DownloadQuery::FILTER_FIELD_BYTES_RECEIVED, 1);
+ Search();
+ EXPECT_EQ(1U, results()->size());
+}
+
+TEST_F(DownloadQueryTest, FilterUrlRegex) {
+ CreateMocks(3);
+ GURL url0("http://example.com");
+ GURL url1("http://foo.com");
+ GURL url2("http://bar.com/foo/bar");
+ EXPECT_CALL(mock(0), GetOriginalUrl()).WillOnce(ReturnRef(url0));
+ EXPECT_CALL(mock(1), GetOriginalUrl()).WillOnce(ReturnRef(url1));
+ EXPECT_CALL(mock(2), GetOriginalUrl()).WillOnce(ReturnRef(url2));
+ query()->Filter(DownloadQuery::FILTER_FIELD_URL_REGEX, std::string("fo{2}"));
+ Search();
+ EXPECT_EQ(2U, results()->size());
+}
+
+TEST_F(DownloadQueryTest, FilterFilter) {
+ CreateMocks(2);
+ EXPECT_CALL(mock(0), GetId()).WillOnce(Return(0));
+ EXPECT_CALL(mock(1), GetId()).WillOnce(Return(1));
+ query()->Filter(base::Bind(&OnlyEvenIds));
+ Search();
+ EXPECT_EQ(1U, results()->size());
+}
+
+TEST_F(DownloadQueryTest, InvalidFilter) {
+ EXPECT_FALSE(query()->Filter(DownloadQuery::FILTER_FIELD_FILENAME_REGEX,
+ std::string()));
+ EXPECT_FALSE(query()->Filter(DownloadQuery::FILTER_FIELD_URL_REGEX,
+ string16()));
+ DownloadQuery::FilterFieldName kInvalidName =
+ static_cast<DownloadQuery::FilterFieldName>(kint32max);
+ EXPECT_FALSE(query()->Filter(kInvalidName, 0));
+ EXPECT_FALSE(query()->Filter(kInvalidName, false));
+ EXPECT_FALSE(query()->Filter(kInvalidName, std::string()));
+ EXPECT_FALSE(query()->Filter(kInvalidName, string16()));
+ EXPECT_FALSE(query()->Filter(kInvalidName, DownloadStateInfo::DANGEROUS_URL));
+ EXPECT_FALSE(query()->Filter(kInvalidName, DownloadItem::IN_PROGRESS));
+}
+
+TEST_F(DownloadQueryTest, FilterFilenameRegex) {
+ CreateMocks(2);
+ FilePath file0("/foo/bar");
+ FilePath file1("/a/b/c");
+ EXPECT_CALL(mock(0), GetFullPath()).WillOnce(ReturnRef(file0));
+ EXPECT_CALL(mock(1), GetFullPath()).WillOnce(ReturnRef(file1));
+ query()->Filter(DownloadQuery::FILTER_FIELD_FILENAME_REGEX,
+ ASCIIToUTF16("fo{2}"));
+ Search();
+ EXPECT_EQ(1U, results()->size());
+}

Powered by Google App Engine
This is Rietveld 408576698