Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: content/browser/download/download_query_unittest.cc

Issue 8601012: DownloadQuery filters and sorts DownloadItems. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Callbacks Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <string>
6
7 #include "base/bind.h"
8 #include "base/file_path.h"
9 #include "base/logging.h"
10 #include "base/stl_util.h"
11 #include "content/browser/download/download_query.h"
12 #include "content/browser/download/mock_download_item.h"
13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h"
15
16 #include "base/utf_string_conversions.h"
17
18 using ::testing::Return;
19 using ::testing::ReturnRef;
20 typedef DownloadQuery::DownloadVector DownloadVector;
21
22 namespace {
23 bool OnlyEvenIds(const DownloadItem& item) {
24 return item.GetId() % 2 == 0;
25 }
26 }
27
28 class DownloadQueryTest : public testing::Test {
29 public:
30 DownloadQueryTest() {}
31 virtual ~DownloadQueryTest() {}
32 virtual void TearDown() {
33 STLDeleteElements(&mocks_);
34 }
35 void CreateMocks(int count) {
36 for (int i = 0; i < count; ++i) {
37 mocks_.push_back(new MockDownloadItem());
38 all_items_.push_back(mocks_[i]);
39 }
40 }
41 MockDownloadItem& mock(int index) { return *mocks_[index]; }
42 DownloadQuery* query() { return &query_; }
43 DownloadVector* all_items() { return &all_items_; }
44 DownloadVector* results() { return &results_; }
45 void Search() {
46 query()->Search(all_items_.begin(), all_items_.end(), &results_);
47 }
48
49 private:
50 std::vector<MockDownloadItem*> mocks_;
51 DownloadQuery query_;
52 DownloadVector all_items_;
53 DownloadVector results_;
54
55 DISALLOW_COPY_AND_ASSIGN(DownloadQueryTest);
56 };
57
58 TEST_F(DownloadQueryTest, EmptyQueryNoItems) {
59 Search();
60 EXPECT_EQ(0U, results()->size());
61 }
62
63 TEST_F(DownloadQueryTest, EmptyQuerySomeItems) {
64 CreateMocks(3);
65 Search();
66 EXPECT_EQ(3U, results()->size());
67 }
68
69 TEST_F(DownloadQueryTest, FilterBytesReceived) {
70 CreateMocks(2);
71 EXPECT_CALL(mock(0), GetReceivedBytes()).WillOnce(Return(0));
72 EXPECT_CALL(mock(1), GetReceivedBytes()).WillOnce(Return(1));
73 query()->Filter(DownloadQuery::FILTER_FIELD_BYTES_RECEIVED, 1);
74 Search();
75 EXPECT_EQ(1U, results()->size());
76 }
77
78 TEST_F(DownloadQueryTest, FilterUrlRegex) {
79 CreateMocks(3);
80 GURL url0("http://example.com");
81 GURL url1("http://foo.com");
82 GURL url2("http://bar.com/foo/bar");
83 EXPECT_CALL(mock(0), GetOriginalUrl()).WillOnce(ReturnRef(url0));
84 EXPECT_CALL(mock(1), GetOriginalUrl()).WillOnce(ReturnRef(url1));
85 EXPECT_CALL(mock(2), GetOriginalUrl()).WillOnce(ReturnRef(url2));
86 query()->Filter(DownloadQuery::FILTER_FIELD_URL_REGEX, std::string("fo{2}"));
87 Search();
88 EXPECT_EQ(2U, results()->size());
89 }
90
91 TEST_F(DownloadQueryTest, FilterFilter) {
92 CreateMocks(2);
93 EXPECT_CALL(mock(0), GetId()).WillOnce(Return(0));
94 EXPECT_CALL(mock(1), GetId()).WillOnce(Return(1));
95 query()->Filter(base::Bind(&OnlyEvenIds));
96 Search();
97 EXPECT_EQ(1U, results()->size());
98 }
99
100 TEST_F(DownloadQueryTest, InvalidFilter) {
101 EXPECT_FALSE(query()->Filter(DownloadQuery::FILTER_FIELD_FILENAME_REGEX,
102 std::string()));
103 EXPECT_FALSE(query()->Filter(DownloadQuery::FILTER_FIELD_URL_REGEX,
104 string16()));
105 DownloadQuery::FilterFieldName kInvalidName =
106 static_cast<DownloadQuery::FilterFieldName>(kint32max);
107 EXPECT_FALSE(query()->Filter(kInvalidName, 0));
108 EXPECT_FALSE(query()->Filter(kInvalidName, false));
109 EXPECT_FALSE(query()->Filter(kInvalidName, std::string()));
110 EXPECT_FALSE(query()->Filter(kInvalidName, string16()));
111 EXPECT_FALSE(query()->Filter(kInvalidName, DownloadStateInfo::DANGEROUS_URL));
112 EXPECT_FALSE(query()->Filter(kInvalidName, DownloadItem::IN_PROGRESS));
113 }
114
115 TEST_F(DownloadQueryTest, FilterFilenameRegex) {
116 CreateMocks(2);
117 FilePath file0("/foo/bar");
118 FilePath file1("/a/b/c");
119 EXPECT_CALL(mock(0), GetFullPath()).WillOnce(ReturnRef(file0));
120 EXPECT_CALL(mock(1), GetFullPath()).WillOnce(ReturnRef(file1));
121 query()->Filter(DownloadQuery::FILTER_FIELD_FILENAME_REGEX,
122 ASCIIToUTF16("fo{2}"));
123 Search();
124 EXPECT_EQ(1U, results()->size());
125 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698