Expose the Crypto and SubtleCrypto interface objects

Expose the Crypto and SubtleCrypto interface objects

Per spec Crypto, CryptoKey and SubtleCrypto are all exposed:
https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#crypto-interface
https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#cryptokey-interface
https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#subtlecrypto-interface

Firefox Nightly already exposes all three, while IE11 exposes
Crypto and SubtleCrypto.

BUG=450064
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188653

[philipj_slow, 2015-01-19 12:52:44]

philipj@opera.com changed reviewers:
+ eroman@chromium.org

[philipj_slow, 2015-01-19 12:52:45]

PTAL, like https://codereview.chromium.org/845633002

[eroman, 2015-01-19 19:47:17]

This additionally needs:
  Exposed=(Window,Worker)

Otherwise the interface won't be exposed in WebWorkers.

For the record, these spec changes originated from:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25390

(Since originally the interfaces were not exposed).

Could you also add a simple test to verify that WebWorkers can see these
interface? (You can copy the style used for CryptoKey and add an "instanceof"
test to that one worker test).

Thanks, otherwise looksgood!

[philipj_slow, 2015-01-19 20:56:51]

Exposed=(Window,Worker)

[philipj_slow, 2015-01-19 21:03:48]

On 2015/01/19 19:47:17, eroman wrote:
> This additionally needs:
>   Exposed=(Window,Worker)
> 
> Otherwise the interface won't be exposed in WebWorkers.
> 
> For the record, these spec changes originated from:
> https://www.w3.org/Bugs/Public/show_bug.cgi?id=25390
> 
> (Since originally the interfaces were not exposed).

Thanks, I didn't know the reason, for a bunch of interfaces it was an accident
of history, but not in this case it seems.

> Could you also add a simple test to verify that WebWorkers can see these
> interface? (You can copy the style used for CryptoKey and add an "instanceof"
> test to that one worker test).

I've updated the test expectations for the now re-enabled webexposed tests, see
https://codereview.chromium.org/813043004 for the corresponding CryptoKey
changes.

Is this enough, or do you also want tests for "crypto instanceof Crypto" and
"crypto.subtle instanceof SubtleCrypto"?

[eroman, 2015-01-19 22:06:35]

LGTM, thanks!

yes those test are sufficient, in fact I didn't know about them :)

[philipj_slow, 2015-01-19 23:27:49]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-01-19 23:28:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/859733002/20001

[philipj_slow, 2015-01-19 23:28:56]

On 2015/01/19 22:06:35, eroman wrote:
> LGTM, thanks!
> 
> yes those test are sufficient, in fact I didn't know about them :)

Yeah, they were disabled when you did the CryptoKey change. Thanks for the
review!

[commit-bot: I haz the power, 2015-01-20 01:17:06]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188653