Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 845633002: Remove NoInterfaceObject attribute from CryptoKey. (Closed)

Created:
5 years, 11 months ago by eroman
Modified:
5 years, 11 months ago
Reviewers:
jww
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove NoInterfaceObject attribute from CryptoKey. This matches the definition in the spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#cryptokey-interface BUG=447347 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188094

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Expose to Workers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
A LayoutTests/crypto/subtle/cryptokey-interface-is-visible.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/subtle/cryptokey-interface-is-visible-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/subtle/resources/subtle-crypto-concurrent.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/CryptoKey.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
eroman
5 years, 11 months ago (2015-01-08 22:01:33 UTC) #2
eroman
Actually my change is incomplete, needs to test and expose for Workers as well
5 years, 11 months ago (2015-01-08 22:05:05 UTC) #3
eroman
Fixed, PTAL!
5 years, 11 months ago (2015-01-08 22:15:49 UTC) #4
jww
lgtm
5 years, 11 months ago (2015-01-09 00:32:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845633002/40001
5 years, 11 months ago (2015-01-09 01:35:15 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 01:38:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188094

Powered by Google App Engine
This is Rietveld 408576698