Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: pkg/analyzer/lib/instrumentation/instrumentation.dart

Issue 859513002: send priority instrumentation message on startup with version info (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge and address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/instrumentation/instrumentation.dart
diff --git a/pkg/analyzer/lib/instrumentation/instrumentation.dart b/pkg/analyzer/lib/instrumentation/instrumentation.dart
index 1d890eb3675ec19c4338ef17b759e4d9c70d38bf..0cf572433fcbb8735a12ec4545c40d353e83e477 100644
--- a/pkg/analyzer/lib/instrumentation/instrumentation.dart
+++ b/pkg/analyzer/lib/instrumentation/instrumentation.dart
@@ -178,6 +178,29 @@ class InstrumentationService {
}
/**
+ * Signal that the client has started analysis server.
+ * This method should be invoked exactly one time.
+ */
+ void logVersion(String uuid, String clientId, String clientVersion,
+ String serverVersion, String sdkVersion) {
+
+ String normalize(String value) =>
+ value != null && value.length > 0 ? value : 'unknown';
+
+ if (_instrumentationServer != null) {
+ _instrumentationServer.logWithPriority(
+ _join(
+ [
+ TAG_VERSION,
+ uuid,
+ normalize(clientId),
+ normalize(clientVersion),
+ serverVersion,
+ sdkVersion]));
+ }
+ }
+
+ /**
* Signal that the client is done communicating with the instrumentation
* server. This method should be invoked exactly one time and no other methods
* should be invoked on this instance after this method has been invoked.
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analyzer/test/instrumentation/instrumentation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698