Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: pkg/analyzer/test/instrumentation/instrumentation_test.dart

Issue 859513002: send priority instrumentation message on startup with version info (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge and address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/instrumentation/instrumentation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/instrumentation/instrumentation_test.dart
diff --git a/pkg/analyzer/test/instrumentation/instrumentation_test.dart b/pkg/analyzer/test/instrumentation/instrumentation_test.dart
index ec2aa7c9f2ab74b73645edc56c656ee6c7f7b63b..30de8191dfc3664185245cedda7264b0c558b59f 100644
--- a/pkg/analyzer/test/instrumentation/instrumentation_test.dart
+++ b/pkg/analyzer/test/instrumentation/instrumentation_test.dart
@@ -105,6 +105,22 @@ class InstrumentationServiceTest {
service.logResponse(message);
assertNormal(server, InstrumentationService.TAG_RESPONSE, message);
}
+
+ void test_logVersion() {
+ TestInstrumentationServer server = new TestInstrumentationServer();
+ InstrumentationService service = new InstrumentationService(server);
+ service.logVersion(
+ 'myUuid',
+ 'someClientId',
+ 'someClientVersion',
+ 'aServerVersion',
+ 'anSdkVersion');
+ expect(server.normalChannel.toString(), '');
+ expect(
+ server.priorityChannel.toString(),
+ endsWith(
+ ':myUuid:someClientId:someClientVersion:aServerVersion:anSdkVersion\n'));
+ }
}
@reflectiveTest
« no previous file with comments | « pkg/analyzer/lib/instrumentation/instrumentation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698