Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 858983002: Skip direct map from apk check for Samsung Mega. (Closed)

Created:
5 years, 11 months ago by Andrew Hayden (chromium.org)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2272
Target Ref:
refs/pending/branch-heads/2272
Project:
chromium
Visibility:
Public.

Description

Skip direct map from apk check for Samsung Mega. Avoid a warning from Samsung knox by skipping attempts to mmap the apk file for UMA data. Instead return false, appropriate since any attempt later to really map the file would similarly trigger this knox warning. BUG=448084 Review URL: https://codereview.chromium.org/857833002 Cr-Commit-Position: refs/heads/master@{#312138} (cherry picked from commit fba86e9cdbf10b89e6b644dbf1451cd67fa53e4f) R=rmcilroy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/86948ef332b3eb11aa1cf67a2ce3935f4b91e788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
rmcilroy
On 2015/01/20 09:48:55, Andrew Hayden wrote: > mailto:andrewhayden@chromium.org changed reviewers: > + mailto:kerz@chromium.org, mailto:rmcilroy@chromium.org, mailto:simonb@chromium.org ...
5 years, 11 months ago (2015-01-20 09:50:27 UTC) #2
Andrew Hayden (chromium.org)
5 years, 11 months ago (2015-01-20 09:53:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86948ef332b3eb11aa1cf67a2ce3935f4b91e788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698