Skip direct map from apk check for Samsung Mega.

Skip direct map from apk check for Samsung Mega.

Avoid a warning from Samsung knox by skipping attempts to mmap
the apk file for UMA data.  Instead return false, appropriate
since any attempt later to really map the file would similarly
trigger this knox warning.

BUG=448084
Committed: https://crrev.com/fba86e9cdbf10b89e6b644dbf1451cd67fa53e4f
Cr-Commit-Position: refs/heads/master@{#312138}

[Andrew Hayden (chromium.org), 2015-01-19 18:23:37]

andrewhayden@chromium.org changed reviewers:
+ andrewhayden@chromium.org

[Andrew Hayden (chromium.org), 2015-01-19 18:23:37]

Manually verified with Simon. LGTM, but I'm not an owner for this area.

[rmcilroy, 2015-01-19 18:27:20]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2015-01-19 18:27:20]

lgtm, with a comment.  Thanks Simon!

https://codereview.chromium.org/857833002/diff/1/base/android/java/src/org/ch...
File base/android/java/src/org/chromium/base/library_loader/Linker.java (right):

https://codereview.chromium.org/857833002/diff/1/base/android/java/src/org/ch...
base/android/java/src/org/chromium/base/library_loader/Linker.java:852: if
(model != null && model.equals("GT-I9205")) {
Do we want to check the Android version too? We only know about this bug on
4.2.2 but I'm not sure if it occurs on all versions.  Any ideas Andrew?

[Andrew Hayden (chromium.org), 2015-01-19 18:44:34]

On 2015/01/19 18:27:20, rmcilroy wrote:
> lgtm, with a comment.  Thanks Simon!
> 
>
https://codereview.chromium.org/857833002/diff/1/base/android/java/src/org/ch...
> File base/android/java/src/org/chromium/base/library_loader/Linker.java
(right):
> 
>
https://codereview.chromium.org/857833002/diff/1/base/android/java/src/org/ch...
> base/android/java/src/org/chromium/base/library_loader/Linker.java:852: if
> (model != null && model.equals("GT-I9205")) {
> Do we want to check the Android version too? We only know about this bug on
> 4.2.2 but I'm not sure if it occurs on all versions.  Any ideas Andrew?

We haven't been able to test this case because we don't have the ability to
install Kit Kat or later onto this device. Hopefully we'll be able to get an
answer on that tomorrow, but given what we know about SELinux and Knox so far it
seems unlikely that this issue will be resolved by an update to KitKat.

With the release date creeping up it feels like the right thing to do for M40 is
just disable the check on all these devices regardless of Android version; we
can revisit this in M41.

[simonb (inactive), 2015-01-19 18:44:41]

https://codereview.chromium.org/857833002/diff/1/base/android/java/src/org/ch...
File base/android/java/src/org/chromium/base/library_loader/Linker.java (right):

https://codereview.chromium.org/857833002/diff/1/base/android/java/src/org/ch...
base/android/java/src/org/chromium/base/library_loader/Linker.java:852: if
(model != null && model.equals("GT-I9205")) {
On 2015/01/19 18:27:20, rmcilroy wrote:
> Do we want to check the Android version too? We only know about this bug on
> 4.2.2 but I'm not sure if it occurs on all versions.  Any ideas Andrew?

Andrew and I discussed this.  We decided not, but we can revisit that later. 
For now, best just get this in and merged/ported to branches.

Thanks for the review.

[simonb (inactive), 2015-01-19 18:45:07]

The CQ bit was checked by simonb@chromium.org

[commit-bot: I haz the power, 2015-01-19 18:45:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/857833002/1

[commit-bot: I haz the power, 2015-01-19 19:53:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-19 19:54:46]

Patchset 1 (id:??) landed as
https://crrev.com/fba86e9cdbf10b89e6b644dbf1451cd67fa53e4f
Cr-Commit-Position: refs/heads/master@{#312138}