Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 85893002: Fix generate_trig_table build target. (Closed)

Created:
7 years ago by Yang
Modified:
7 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix generate_trig_table build target. It now closely resembles the js2c target, so that we only have one platform to run it on (either 'host' or 'target'). This way we do not run into warnings when compiling for e.g. ARM. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tools/gyp/v8.gyp View 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years ago (2013-11-25 14:56:42 UTC) #1
Jakob Kummerow
lgtm
7 years ago (2013-11-25 14:58:09 UTC) #2
Yang
7 years ago (2013-11-26 08:50:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18067.

Powered by Google App Engine
This is Rietveld 408576698