Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: tools/gyp/v8.gyp

Issue 85893002: Fix generate_trig_table build target. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 65d5fb89a9303fdee8865feaf6727e59c6303cea..37fd4075986cb8d7074f978402b8a5d7f872925d 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -113,10 +113,15 @@
'dependencies': [
'mksnapshot.<(v8_target_arch)#host',
'js2c#host',
+ 'generate_trig_table#host',
],
}, {
'toolsets': ['target'],
- 'dependencies': ['mksnapshot.<(v8_target_arch)', 'js2c'],
+ 'dependencies': [
+ 'mksnapshot.<(v8_target_arch)',
+ 'js2c',
+ 'generate_trig_table',
+ ],
}],
['component=="shared_library"', {
'defines': [
@@ -189,10 +194,10 @@
'conditions': [
['want_separate_host_toolset==1', {
'toolsets': ['host', 'target'],
- 'dependencies': ['js2c#host'],
+ 'dependencies': ['js2c#host', 'generate_trig_table#host'],
}, {
'toolsets': ['target'],
- 'dependencies': ['js2c'],
+ 'dependencies': ['js2c', 'generate_trig_table'],
}],
['component=="shared_library"', {
'defines': [
@@ -206,7 +211,7 @@
'type': 'none',
'conditions': [
['want_separate_host_toolset==1', {
- 'toolsets': ['host', 'target'],
+ 'toolsets': ['host'],
}, {
'toolsets': ['target'],
}],
@@ -231,9 +236,6 @@
{
'target_name': 'v8_base.<(v8_target_arch)',
'type': 'static_library',
- 'dependencies': [
- 'generate_trig_table',
- ],
'variables': {
'optimize': 'max',
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698