Remove DCHECK which causes crash in PDFs with email attachments.

Remove DCHECK which causes crash in PDFs with email attachments.

It isn't right to have a DCHECK here, instead we should just ignore the params.

Committed: https://crrev.com/fc73480148a774e367c6667b0844f5e6cf6735cb
Cr-Commit-Position: refs/heads/master@{#312060}

[raymes, 2015-01-16 00:29:44]

raymes@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-01-16 00:47:18]

Alternatively, we could just not support the MailForm() method in the JS Acrobat
API. i.e. return false in Document::mailForm(). Then no callers would ever pass
non-zero here.

[raymes, 2015-01-16 02:35:44]

Hmm I'm not sure what you mean exactly. What that mean not allowing forms
to be emailed at all? Would it be better to keep that functionality?

On Fri Jan 16 2015 at 11:47:20 AM <thestig@chromium.org> wrote:

> Alternatively, we could just not support the MailForm() method in the JS
> Acrobat
> API. i.e. return false in Document::mailForm(). Then no callers would ever
> pass
> non-zero here.
>
> https://codereview.chromium.org/858443002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Lei Zhang, 2015-01-16 03:16:38]

On 2015/01/16 02:35:44, raymes wrote:
> Hmm I'm not sure what you mean exactly. What that mean not allowing forms
> to be emailed at all? Would it be better to keep that functionality?

The JS API has MailMsg(), MailDoc(), and MailForm().

- MailMsg() has no attachment.
- MailDoc() is suppose to attach the PDF, but the pdfium impl attached nothing.
- MailForm() is suppose to attach the form in "FDF" format, and actualy does.
Thus we can fail the DCHECK right now.

I suppose we shouldn't change pdfium to disable MailForm(), as there can be
other users that can handle attachments. So LGTM.

[raymes, 2015-01-18 22:09:49]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-01-18 22:10:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858443002/1

[commit-bot: I haz the power, 2015-01-19 03:44:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-19 03:46:41]

Patchset 1 (id:??) landed as
https://crrev.com/fc73480148a774e367c6667b0844f5e6cf6735cb
Cr-Commit-Position: refs/heads/master@{#312060}