pdf/pdfium/pdfium_engine.cc - Issue 858443002: Remove DCHECK which causes crash in PDFs with email attachments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 858443002: Remove DCHECK which causes crash in PDFs with email attachments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 87f8d65dc90e3a09695495146564febe52b6ce6c..f390e30f02589d0f4a98f55887de965b44487e98 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -3615,7 +3615,8 @@ void PDFiumEngine::Form_Mail(IPDF_JSPLATFORM* param,

FPDF_WIDESTRING cc,

FPDF_WIDESTRING bcc,

FPDF_WIDESTRING message) {

- DCHECK(length == 0); // Don't handle attachments; no way with mailto.

+ // Note: |mail_data| and |length| are ignored. We don't handle attachments;

+ // there is no way with mailto.

std::string to_str =

base::UTF16ToUTF8(reinterpret_cast<const base::char16*>(to));

std::string cc_str =

« no previous file with comments | « no previous file | no next file » | no next file with comments »