--enable-gpu-rasterization flag for turning on hybrid ganesh mode

--enable-gpu-rasterization flag for turning on hybrid ganesh mode

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237482

[humper, 2013-11-25 22:34:34]

PTAL

https://codereview.chromium.org/85813003/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/chrome_restart_request.cc (right):

https://codereview.chromium.org/85813003/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/chrome_restart_request.cc:51: // Increase logging
level for Guest mode to avoid INFO messages in logs.
Had to make this change because the slightly overzealous presubmit scripts saw
LOG(INFO) and said "no, you can't upload this CL", even though it was in a
comment.

[enne (OOO), 2013-11-25 22:43:31]

lgtm

Can you follow up in another patch and make this a LayerTreeSetting too and have
RenderWidgetCompositor::Create call this new IsGPURasterizationEnabled()
function and set that LayerTreeSetting from it?

https://codereview.chromium.org/85813003/diff/20001/cc/base/switches.cc
File cc/base/switches.cc (right):

https://codereview.chromium.org/85813003/diff/20001/cc/base/switches.cc#newco...
cc/base/switches.cc:45: // the Skia GPU backend.  Only valid with gl rendering +
threaded compositing +
To be future proof, I wouldn't mention threaded compositing here.  Impl-side
painting depends on threaded compositing (for now), but
--enable-gpu-rasterization only does indirectly because it depends on impl-side
painting.

https://codereview.chromium.org/85813003/diff/20001/cc/base/switches.cc#newco...
cc/base/switches.cc:47: 
nit: empty line doesn't match style of rest of the file

[Vangelis Kokkevis, 2013-11-25 22:53:51]

Mind you that there's also this CL here:
https://codereview.chromium.org/69123002/

which looks like it got reverted but depending on which of the two lands first
there will be some adjustments needed.

https://codereview.chromium.org/85813003/diff/20001/cc/base/switches.cc
File cc/base/switches.cc (right):

https://codereview.chromium.org/85813003/diff/20001/cc/base/switches.cc#newco...
cc/base/switches.cc:45: // the Skia GPU backend.  Only valid with gl rendering +
threaded compositing +
On 2013/11/25 22:43:32, enne wrote:
> To be future proof, I wouldn't mention threaded compositing here.  Impl-side
> painting depends on threaded compositing (for now), but
> --enable-gpu-rasterization only does indirectly because it depends on
impl-side
> painting.

And  instead of "gl rendering" this should probably be "GPU accelerated
compositing"

[nduca, 2013-11-26 08:08:37]

lgtm when everyone else is happy

[commit-bot: I haz the power, 2013-11-26 15:43:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/humper@google.com/85813003/40001

[commit-bot: I haz the power, 2013-11-26 15:59:09]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[humper, 2013-11-26 16:08:41]

thakis@chromium.org: Please review changes in
chrome/browser/chromeos/login/chrome_restart_request.cc	and
content/browser/renderer_host/render_process_host_impl.cc

[Nico, 2013-11-26 21:59:46]

lgtm

[commit-bot: I haz the power, 2013-11-26 23:02:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/humper@google.com/85813003/40001

[commit-bot: I haz the power, 2013-11-26 23:02:39]

Failed to apply patch for
chrome/browser/chromeos/login/chrome_restart_request.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chromeos/login/chrome_restart_request.cc
  Hunk #1 FAILED at 48.
  Hunk #2 succeeded at 170 (offset 1 line).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/login/chrome_restart_request.cc.rej

Patch:       chrome/browser/chromeos/login/chrome_restart_request.cc
Index: chrome/browser/chromeos/login/chrome_restart_request.cc
diff --git a/chrome/browser/chromeos/login/chrome_restart_request.cc
b/chrome/browser/chromeos/login/chrome_restart_request.cc
index
27427658aee55701931f6f1d38c688c22cec6ec0..414ba657321526a5178cfc00902188350afa34fb
100644
--- a/chrome/browser/chromeos/login/chrome_restart_request.cc
+++ b/chrome/browser/chromeos/login/chrome_restart_request.cc
@@ -48,7 +48,7 @@ namespace chromeos {
 
 namespace {
 
-// Increase logging level for Guest mode to avoid LOG(INFO) messages in logs.
+// Increase logging level for Guest mode to avoid INFO messages in logs.
 const char kGuestModeLoggingLevel[] = "1";
 
 // Format of command line switch.
@@ -169,6 +169,7 @@ std::string DeriveCommandLine(const GURL& start_url,
       cc::switches::kDisableImplSidePainting,
       cc::switches::kDisableMapImage,
       cc::switches::kDisableThreadedAnimation,
+      cc::switches::kEnableGPURasterization,
       cc::switches::kEnableImplSidePainting,
       cc::switches::kEnableMapImage,
       cc::switches::kEnablePartialSwap,

[commit-bot: I haz the power, 2013-11-26 23:14:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/humper@google.com/85813003/60001

[commit-bot: I haz the power, 2013-11-27 02:01:50]

Change committed as 237482