Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: mojo/services/view_manager/public/cpp/lib/view.cc

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase for trybots (no code changes from ps2) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/cpp/lib/view.cc
diff --git a/mojo/services/view_manager/public/cpp/lib/view.cc b/mojo/services/view_manager/public/cpp/lib/view.cc
index 6848a316ffc220330b4af73ba81ae8ba2a9f7239..929eec494576ed14f25ab746a8b19d023e293074 100644
--- a/mojo/services/view_manager/public/cpp/lib/view.cc
+++ b/mojo/services/view_manager/public/cpp/lib/view.cc
@@ -359,26 +359,11 @@ void View::Embed(const String& url) {
static_cast<ViewManagerClientImpl*>(manager_)->Embed(url, id_);
}
-scoped_ptr<ServiceProvider>
- View::Embed(const String& url,
- scoped_ptr<ServiceProviderImpl> exported_services) {
- scoped_ptr<ServiceProvider> imported_services;
- // BindToProxy() takes ownership of |exported_services|.
- ServiceProviderImpl* registry = exported_services.release();
- ServiceProviderPtr sp;
- if (registry) {
- BindToProxy(registry, &sp);
- imported_services.reset(registry->CreateRemoteServiceProvider());
- }
- static_cast<ViewManagerClientImpl*>(manager_)
- ->Embed(url, id_, MakeRequest<ServiceProvider>(sp.PassMessagePipe()));
- return imported_services.Pass();
-}
-
void View::Embed(const String& url,
- InterfaceRequest<ServiceProvider> exported_services) {
+ InterfaceRequest<ServiceProvider> services,
+ ServiceProviderPtr exposed_services) {
static_cast<ViewManagerClientImpl*>(manager_)
- ->Embed(url, id_, exported_services.Pass());
+ ->Embed(url, id_, services.Pass(), exposed_services.Pass());
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « mojo/services/public/js/shell.js ('k') | mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698