mojo/services/public/js/shell.js - Issue 858103002: Remove [Client=] annotation from ServiceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/js/shell.js

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: rebase for trybots (no code changes from ps2) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/public/js/shell.js

diff --git a/mojo/services/public/js/shell.js b/mojo/services/public/js/shell.js

index 8d90dcb2f579a61171cd1afb2bb61b9830010799..9fc8552f82748fc56ca87d7483fce7fc7f9f6e03 100644

--- a/mojo/services/public/js/shell.js

+++ b/mojo/services/public/js/shell.js

@@ -33,8 +33,10 @@ define("mojo/services/public/js/shell", [

if (application)

return application;

- this.proxy.connectToApplication(url, function(sp) {

- application = new ServiceProvider(sp);

+ this.proxy.connectToApplication(url, function(services) {

+ application = new ServiceProvider(services);

+ }, function() {

+ return application;

});

this.applications_.set(url, application);

return application;