mojo/services/window_manager/public/interfaces/window_manager.mojom - Issue 858103002: Remove [Client=] annotation from ServiceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/window_manager/public/interfaces/window_manager.mojom

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/services/view_manager/public/interfaces/view_manager.mojom ('K') | « mojo/services/view_manager/public/interfaces/view_manager.mojom ('k') | services/view_manager/connection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/window_manager/public/interfaces/window_manager.mojom

diff --git a/mojo/services/window_manager/public/interfaces/window_manager.mojom b/mojo/services/window_manager/public/interfaces/window_manager.mojom

index a2ef5945d92dd7bca41be26b64a35cfb80c73821..6a34820d17ffb2077e338035df2e6da5dca4b4ab 100644

--- a/mojo/services/window_manager/public/interfaces/window_manager.mojom

+++ b/mojo/services/window_manager/public/interfaces/window_manager.mojom

@@ -10,8 +10,8 @@ import "mojo/public/interfaces/application/service_provider.mojom";

[Client=WindowManagerClient]

interface WindowManager {

// Requests the WindowManager to embed the app for |url| at an appropriate

- // View. See ViewMangerService::Embed() for details on |service_provider|.

- Embed(string url, ServiceProvider& service_provider);

+ // View. See ViewMangerService::Embed() for details on |services| and |exposed_services|.

sky 2015/01/21 16:59:00 nit: > 80

jamesr 2015/01/21 18:51:40 Done.

+ Embed(string url, ServiceProvider&? services, ServiceProvider? exposed_services);

sky 2015/01/21 16:59:00 Again, can we make these not optional?

jamesr 2015/01/21 18:51:40 No

SetCapture(uint32 view_id) => (bool success);

FocusWindow(uint32 view_id) => (bool success);