Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: mojo/services/window_manager/public/interfaces/window_manager.mojom

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module mojo; 5 module mojo;
6 6
7 import "input_events/public/interfaces/input_events.mojom"; 7 import "input_events/public/interfaces/input_events.mojom";
8 import "mojo/public/interfaces/application/service_provider.mojom"; 8 import "mojo/public/interfaces/application/service_provider.mojom";
9 9
10 [Client=WindowManagerClient] 10 [Client=WindowManagerClient]
11 interface WindowManager { 11 interface WindowManager {
12 // Requests the WindowManager to embed the app for |url| at an appropriate 12 // Requests the WindowManager to embed the app for |url| at an appropriate
13 // View. See ViewMangerService::Embed() for details on |service_provider|. 13 // View. See ViewMangerService::Embed() for details on |services| and |exposed _services|.
sky 2015/01/21 16:59:00 nit: > 80
jamesr 2015/01/21 18:51:40 Done.
14 Embed(string url, ServiceProvider& service_provider); 14 Embed(string url, ServiceProvider&? services, ServiceProvider? exposed_service s);
sky 2015/01/21 16:59:00 Again, can we make these not optional?
jamesr 2015/01/21 18:51:40 No
15 15
16 SetCapture(uint32 view_id) => (bool success); 16 SetCapture(uint32 view_id) => (bool success);
17 FocusWindow(uint32 view_id) => (bool success); 17 FocusWindow(uint32 view_id) => (bool success);
18 ActivateWindow(uint32 view_id) => (bool success); 18 ActivateWindow(uint32 view_id) => (bool success);
19 19
20 GetFocusedAndActiveViews() => (uint32 focused_view_id, uint32 active_view_id); 20 GetFocusedAndActiveViews() => (uint32 focused_view_id, uint32 active_view_id);
21 }; 21 };
22 22
23 interface WindowManagerClient { 23 interface WindowManagerClient {
24 OnCaptureChanged(uint32 old_capture_view_id, uint32 new_capture_view_id); 24 OnCaptureChanged(uint32 old_capture_view_id, uint32 new_capture_view_id);
25 OnFocusChanged(uint32 old_focused_view_id, uint32 new_focused_view_id); 25 OnFocusChanged(uint32 old_focused_view_id, uint32 new_focused_view_id);
26 OnActiveWindowChanged(uint32 old_focused_view_id, uint32 new_focused_view_id); 26 OnActiveWindowChanged(uint32 old_focused_view_id, uint32 new_focused_view_id);
27 }; 27 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698