Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 857573004: Fix chromium-style errors for WeakPtrFactory member order in Chromecast (Closed)

Created:
5 years, 11 months ago by halliwell
Modified:
5 years, 11 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chromium-style errors for WeakPtrFactory member order in Chromecast This check just got turned on upstream, see crrev.com/803603003 BUG= Committed: https://crrev.com/adb1f46b1ac3c7d353173669bf51512caf48fd02 Cr-Commit-Position: refs/heads/master@{#311920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chromecast/media/cma/pipeline/audio_pipeline_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/pipeline/av_pipeline_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/pipeline/media_pipeline_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/pipeline/video_pipeline_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
halliwell
5 years, 11 months ago (2015-01-16 15:37:08 UTC) #2
lcwu1
lgtm
5 years, 11 months ago (2015-01-16 16:46:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857573004/1
5 years, 11 months ago (2015-01-16 17:00:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 17:44:58 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 17:46:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/adb1f46b1ac3c7d353173669bf51512caf48fd02
Cr-Commit-Position: refs/heads/master@{#311920}

Powered by Google App Engine
This is Rietveld 408576698